Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom tooling repo support #628

Closed

Conversation

MiahaCybersec
Copy link
Contributor

Closes #598

Signed-off-by: Miaha Cybersec <[email protected]>
Signed-off-by: Miaha Cybersec <[email protected]>
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 33.85%. Comparing base (2602d59) to head (728df52).
Report is 67 commits behind head on main.

Files Patch % Lines
pkg/patch/patch.go 0.00% 7 Missing ⚠️
pkg/pkgmgr/dpkg.go 50.00% 4 Missing ⚠️
pkg/pkgmgr/apk.go 0.00% 2 Missing ⚠️
pkg/pkgmgr/rpm.go 0.00% 2 Missing ⚠️
pkg/patch/cmd.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   32.51%   33.85%   +1.34%     
==========================================
  Files          17       18       +1     
  Lines        1621     1527      -94     
==========================================
- Hits          527      517      -10     
+ Misses       1062      977      -85     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miaha Cybersec <[email protected]>
@sozercan
Copy link
Member

do we still need this with the source policies? https://project-copacetic.github.io/copacetic/website/faq#can-i-replace-the-package-repositories-in-the-image-with-my-own

@MiahaCybersec
Copy link
Contributor Author

After taking a look, this could potentially be seen as redundant. Do we still want a user flag for this kind of behaviour, or do we want the user to pass in these custom values exclusively via BuildKit source policies?

If this PR is still wanted, please let me know so I can make the necessary changes before it gets merged. I noticed this morning that I forgot to add some logic in dpkg.go to pass the new variable into the appropriate functions if a custom tooling repo is passed in.

@MiahaCybersec MiahaCybersec deleted the qualify-image-repo branch May 20, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REQ] Add support for qualifying image name with designated repository
2 participants