Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

do not navigate, when we don't have jobs loaded yet. #1001

Closed
wants to merge 1 commit into from
Closed

do not navigate, when we don't have jobs loaded yet. #1001

wants to merge 1 commit into from

Conversation

okias
Copy link

@okias okias commented Jun 11, 2022

Description

Catch out-of-bound exception

Related Issue

Resolves #991

How Has This Been Tested?

Runtime tested, on linux, amd64

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@okias
Copy link
Author

okias commented Jun 11, 2022

Would be nice to have something like "Loading the pipeline..." or something informative on screen. what do you people think?

@clemsbot
Copy link
Collaborator

This PR has been automatically marked as stale because it has not had recent activity. This message is just a reminder for the author, reviewers and assignees.

@clemsbot clemsbot added the stale label Jul 28, 2022
@okias
Copy link
Author

okias commented Jul 28, 2022

not stale, please merge. Also DeepSource: Go seems to noticed unrelated issues(?)

@profclems
Copy link
Owner

profclems commented Aug 9, 2022

Hi @okias, thanks a lot for this PR. I love this, however, we announced that this project is officially adopted by GitLab #983 (comment). All new contributions should be made to the GitLab repo: https://gitlab.com/gitlab-org/cli

@okias
Copy link
Author

okias commented Aug 9, 2022

@okias okias closed this Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash on mesa CI at gitlab.freedesktop.org
3 participants