Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable compression in cluster mode #139

Open
prodrigestivill opened this issue May 24, 2023 · 0 comments
Open

Allow to disable compression in cluster mode #139

prodrigestivill opened this issue May 24, 2023 · 0 comments

Comments

@prodrigestivill
Copy link
Owner

prodrigestivill commented May 24, 2023

Allow to disable the gzip compression when using cluster mode YES and better document the cluster mode.

Reported by @JohnTheNerd:

[...] I think what tripped me up is that I enabled POSTGRES_CLUSTER and never removed the -Z6 from POSTGRES_EXTRA_OPTS, which made the script fail. Then I removed that option without re-adding the compress option, which of course created a .sql.gz file that was not gzipped, making me believe it is broken.

Nevertheless, I feel like separating out compression from POSTGRES_EXTRA_OPTS could be good because:

  • It would allow uncompressed pg_dumpall backups.
  • It would allow setting the compression level on pg_dumpall backups.
  • I can see others being confused by something similar, but admittedly this is very subjective. Seeing it's documented right in the README, maybe that is more about my lack of attention than anyone else's confusion smile
@prodrigestivill prodrigestivill changed the title feature request: allow to disable compression in cluster mode Allow to disable compression in cluster mode May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant