Skip to content

FES should fetch translations within the same minor version #7813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 of 17 tasks
ksen0 opened this issue May 14, 2025 · 0 comments
Open
2 of 17 tasks

FES should fetch translations within the same minor version #7813

ksen0 opened this issue May 14, 2025 · 0 comments
Labels
Bug Internationalization Relates to 'src/core/internationalization.js'

Comments

@ksen0
Copy link
Member

ksen0 commented May 14, 2025 •
edited
Loading

Increasing access

FES internationalization improvement to match 1.x/2.x difference

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

Feature enhancement details

Currently, FES fetches translations using latest:

p5.js/src/core/internationalization.js

Line 153 in 5f0fcfa

'https://cdn.jsdelivr.net/npm/p5/translations/{{lng}}/{{ns}}.json'

Which results in a. 1.x sketch getting 2.x FES translations, which may be inaccurate. Should fetch within the minor version, but latest patch, for example: if the sketch is 1.11.1, it should get language for 1.11.7 (or whatever is latest)

This should be patched first in 1.x, and then a matching 2.x
@github-actions github-actions bot added the Internationalization Relates to 'src/core/internationalization.js' label May 14, 2025
@ksen0 ksen0 added Bug and removed Internationalization Relates to 'src/core/internationalization.js' Enhancement labels May 14, 2025
@ksen0 ksen0 changed the title FES should fetch translations within the same minor issue FES should fetch translations within the same minor release May 15, 2025
@ksen0 ksen0 changed the title FES should fetch translations within the same minor release FES should fetch translations within the same minor version May 15, 2025
@github-actions github-actions bot added the Internationalization Relates to 'src/core/internationalization.js' label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Internationalization Relates to 'src/core/internationalization.js'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ksen0