Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code editor + preview no longer side-by-side #204

Open
davepagurek opened this issue Apr 14, 2024 · 2 comments
Open

Code editor + preview no longer side-by-side #204

davepagurek opened this issue Apr 14, 2024 · 2 comments
Labels
qa

Comments

@davepagurek
Copy link
Collaborator

image

Not sure if this was intentional or not so feel free to close this if this was, but I noticed that the preview used to be to the left of the code, and now is always on top.
@davepagurek davepagurek added the qa label Apr 14, 2024
@outofambit
Copy link
Collaborator

Hmmm, the designs show a vertical layout for everywhere except the reference pages. (I changed this intentionally in #189) But I'm also seeing they also don't account for code previews that aren't essentially full width. We should figure out what we want here.

@davepagurek
Copy link
Collaborator Author

@Qianqianye do you have an opinion on this one, given not all code previews are full page width?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
qa
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@outofambit @davepagurek