Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: incorrect language tag for JavaScript #106

Open
EshaanAgg opened this issue Mar 30, 2024 · 3 comments
Open

bug: incorrect language tag for JavaScript #106

EshaanAgg opened this issue Mar 30, 2024 · 3 comments

Comments

@EshaanAgg
Copy link
Contributor

In many of the .mdx files containing the documentation, the JavaScript code snippets have been marked with the language tag JavaScript as follows:
image
This tag is incorrect and should be replaced by javascript. These incorrect language tags lead the build by Shiki to not be rendered as JS, but rather plaintext:
image

A simple global search and replacing [triple backticks]JavaScript with [triple backticks]javascript should fix the same.

@EshaanAgg
Copy link
Contributor Author

I can take this issue up if the maintainers approve.

@outofambit
Copy link
Collaborator

just a quick note here that the majority of these are in src/content/contributor-docs, which have to be fixed in the p5 repo and then re-imported here with the build contributor docs script. i see a few in src/content/tutorials, which can be fixed directly in this repo.

@limzykenneth
Copy link
Member

For those in contributor docs, we'll fix in the p5.js repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants