Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the search bar #685

Closed
pcgamer1 opened this issue Apr 13, 2020 · 9 comments · May be fixed by #686
Closed

Changes to the search bar #685

pcgamer1 opened this issue Apr 13, 2020 · 9 comments · May be fixed by #686
Assignees

Comments

@pcgamer1
Copy link
Member

pcgamer1 commented Apr 13, 2020

Actual Behaviour
Search bar is not recognizable for some students when they are new to the website according to
Mr. Raymond G McCord who has responded to my poll in the p5 forum on discourse. He said slight design changes would be helpful for the students.

Expected Behaviour
A more eye-catching search bar.

The modified bar looks like this :
search
@limzykenneth Any suggestions would be helpful.
Would you like to work on the issue?
Yes

@pcgamer1
Copy link
Member Author

@limzykenneth Any suggestions on the PR #700 would be helpful.

@pcgamer1
Copy link
Member Author

@limzykenneth @lmccart This is the search bar that I ended up with after considering several suggestions. Any further suggestions?
The magnifying glass is monochrome, the border is a darker shade of gray and the placeholder text is light gray.
newsearch

@khanjasir90
Copy link

@limzykenneth can i work on this feature!

@montoyamoraga
Copy link
Member

hey @khanjasir90 sure, thanks!

@khanjasir90
Copy link

@montoyamoraga whenever i am making changes in index.html file the changes are not getting reflected instead of starting the server again ! can u pls help

@montoyamoraga
Copy link
Member

hey @khanjasir90, just to double check,
are you following the instructions from
https://github.com/processing/p5.js/tree/main/contributor_docs ?
most sections i have worked on, i modify source files in YAML or another structure,
and then after running grunt, they are transpiled to html, i think most sections of the website
are not programmed directly in HTML :)

@khanjasir90
Copy link

thanks @montoyamoraga one more thing i was about to add search icon in the search bar but was not able to detect the file in which i should add ! can u pls help coz i am a beginner in open source!

@montoyamoraga
Copy link
Member

hi @khanjasir90, thanks!
we are not adding features, unless we are improving access, i suggest either reading all the related issues and pull requests on this thread, or finding another issue you can help us with, this one is a lot of work :)

@khanjasir90
Copy link

thats okay @montoyamoraga

@lmccart lmccart closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants