-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when application has .svg instead of .png icon #285
Comments
At this point I think we should just use the png and delete the svg. svg parsing is just too difficult... |
Can't there be a function that converts the svg to png for programs that don't ship a png in their builds? |
That'd be ImageMagick I guess. You can run it before running fo-appimage's |
This being said, we should make a nice error handler instead of just crashing. |
I'm building an htop appimage and ran into this issue, it is caused because I'm using the included .svg as icon in the build, they also include a .png icon and when using the .png the issue doesn't happen.
I tested the continuos build and version 823, it happens with both. What's weird is that it only happens with this specific .svg icon as I haven't had this issue with other .svg in other appimages before.
Here is the error message:
And here is the script that is being used for the build: https://github.com/Samueru-sama/htop-AppImage/blob/main/htop-appimage.sh
Commenting out line 18 (+ commenting line 19) will cause appimagetool to fail when trying to make the appimage.
I get the same error when trying the script on my pc so it is not limited to the ubuntu runner.
The text was updated successfully, but these errors were encountered: