-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the role of proposal dummy values #14
Labels
documentation
Improvements or additions to documentation
Comments
Good question -- it's really for support that's too large to tractably enumerate, not just infinite support. It is used whenever preferred values are used (it's the "other" token from the PClean paper). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This text implies that
ProposalDummyValue
s are only used for distributions that have infinite (and discrete) support:https://github.com/probcomp/PClean/blob/master/src/distributions/distributions.jl#L10-L14
But
StringPrior
has finite support (there is a maximum length), and it implementsdiscrete_proposal_dummy_value
:https://github.com/probcomp/PClean/blob/master/src/distributions/string_prior.jl#L23-L25
The text was updated successfully, but these errors were encountered: