test: verify cli Promise waits for async callback/command completion

Author: privatenumber

tests/specs/cli.ts

@@ -83,6 +83,42 @@ export default testSuite(({ describe }) => {
 				// And it's awaitable
 				await result;
 			});
+
+			test('cli Promise waits for callback to complete', async () => {
+				let callbackCompleted = false;
+
+				const result = cli({}, async () => {
+					await setImmediate();
+					callbackCompleted = true;
+				});
+
+				// Callback shouldn't have completed yet
+				expect(callbackCompleted).toBe(false);
+
+				// After awaiting cli, callback should be complete
+				await result;
+				expect(callbackCompleted).toBe(true);
+			});
+
+			test('cli Promise never resolves if callback never resolves', async () => {
+				let cliResolved = false;
+
+				const result = cli({}, async () => {
+					// Never resolve - hang forever
+					await new Promise(() => {});
+				});
+
+				// Race the cli promise against a timeout
+				await Promise.race([
+					result.then(() => {
+						cliResolved = true;
+					}),
+					setImmediate(50),
+				]);
+
+				// cli should not have resolved
+				expect(cliResolved).toBe(false);
+			});
 		});
 	});
 });

tests/specs/command.ts

@@ -1,3 +1,4 @@
+import { setImmediate } from 'node:timers/promises';
 import { testSuite, expect } from 'manten';
 import { spy } from 'nanospy';
 import { cli, command } from '#cleye';
@@ -344,5 +345,63 @@ export default testSuite(({ describe }) => {
 				expect(cliCallback.called).toBe(false);
 			});
 		});
+
+		describe('async command callbacks', ({ test }) => {
+			test('cli Promise waits for command callback to complete', async () => {
+				let commandCompleted = false;
+
+				const testCommand = command({
+					name: 'test',
+				}, async () => {
+					await setImmediate();
+					commandCompleted = true;
+				});
+
+				const result = cli(
+					{
+						commands: [testCommand],
+					},
+					undefined,
+					['test'],
+				);
+
+				// Command callback shouldn't have completed yet
+				expect(commandCompleted).toBe(false);
+
+				// After awaiting cli, command callback should be complete
+				await result;
+				expect(commandCompleted).toBe(true);
+			});
+
+			test('cli Promise never resolves if command callback never resolves', async () => {
+				let cliResolved = false;
+
+				const testCommand = command({
+					name: 'test',
+				}, async () => {
+					// Never resolve - hang forever
+					await new Promise(() => {});
+				});
+
+				const result = cli(
+					{
+						commands: [testCommand],
+					},
+					undefined,
+					['test'],
+				);
+
+				// Race the cli promise against a timeout
+				await Promise.race([
+					result.then(() => {
+						cliResolved = true;
+					}),
+					setImmediate(50),
+				]);
+
+				// cli should not have resolved
+				expect(cliResolved).toBe(false);
+			});
+		});
 	});
 });