Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First row below the header in Primer::Beta::Box has rounded corners #2684

Open
HDinger opened this issue Mar 11, 2024 · 0 comments · May be fixed by #2686
Open

First row below the header in Primer::Beta::Box has rounded corners #2684

HDinger opened this issue Mar 11, 2024 · 0 comments · May be fixed by #2686
Labels

Comments

@HDinger
Copy link
Contributor

HDinger commented Mar 11, 2024

Version

0.19.0

Steps to reproduce

e.g.

render(Primer::Beta::BorderBox.new) do |component|
  component.with_header { "Header" }
  component.with_body { "Body" }
  component.with_row { "Row one" }
  component.with_row { "Row two" }
end

Actual behavior

  • The row has additional round corners at the top which looks weird because the header (or the body) is directly at the top:
Bildschirmfoto 2024-03-11 um 14 08 54 Bildschirmfoto 2024-03-11 um 14 09 18
  • This becomes especially obvious in the high contrast themes
  • The same issue appears when there is a body used but no footer:
Bildschirmfoto 2024-03-12 um 08 57 25

Expected behavior

  • There should be no rounded corners if a header (or a body) is defined.
@HDinger HDinger linked a pull request Mar 12, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant