Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formally deprecate Flash and point people to Banner #2599

Closed
khiga8 opened this issue Feb 12, 2024 · 1 comment · Fixed by #2640
Closed

Formally deprecate Flash and point people to Banner #2599

khiga8 opened this issue Feb 12, 2024 · 1 comment · Fixed by #2640
Labels
rails

Comments

@khiga8
Copy link
Contributor

khiga8 commented Feb 12, 2024

See Staff-only Slack context and previous nudges pointing people to use Banner instead of Flash:

Given the past discussion that Banner will replace Flash, it probably makes sense to formally deprecate Flash and/or update docs to point people to Banner.

I am unsure what the formal deprecation process is like but filing for tracking!
@jonrohan
Copy link
Member

We discussed this in the weekly PVC sync, seems reasonable to move forward with this 👍

@khiga8 khiga8 mentioned this issue Feb 26, 2024
Merged
3 tasks
HDinger added a commit to opf/openproject that referenced this issue Mar 4, 2024
@HDinger
Replace Flash with Banner as suggested by Primer (see primer/view…
fa27738 
…_components#2599)
HDinger added a commit to opf/openproject that referenced this issue Mar 4, 2024
@HDinger
Replace Flash with Banner as suggested by Primer (see primer/view…
3f377a2 
…_components#2599)
@HDinger HDinger mentioned this issue Mar 4, 2024
Merged
oliverguenther pushed a commit to opf/openproject that referenced this issue Mar 5, 2024
@HDinger @oliverguenther
Replace Flash with Banner as suggested by Primer (see primer/view…
ab0bad4 
…_components#2599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rails
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark Flash as deprecated primer/view_components
2 participants
@jonrohan @khiga8