-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint rule to ensure <img>
is self closing
#240
Comments
@khiga8 does this happen in the design docs only, or across all primer.style docs? |
This was specifically observed in this design repo in a |
JSX isn't HTML and has its own semantics. One of the ways it differs from HTML is that all elements need to close, either by self-closing or with a closing element.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
<img>
is does not have self closing slash like<img />
, vercel deploys broke completely.<img >
is considered valid HTML as it is a void element, but for some reason<img >
breaks vercel deploys.Apparently
<img>
is not valid in XHTML or XML and needs to be<img />
so maybe XHTML or XML is being used under the hood somewhere? Not sureWe should investigate why this breaks and/or add a lint rule so we catch this at the linting stage and prevent future headaches.
The text was updated successfully, but these errors were encountered: