Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber: buttons don't have type="button" and trigger form submit #5754

Closed
butskristof opened this issue May 17, 2024 · 2 comments
Closed
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@butskristof
Copy link

Describe the bug

If you enable the buttons on InputNumber, they should have a type="button" attribute. They currently don't have this and trigger a form submission if the InputNumber component is used in a <form> tag.

Reproducer

https://stackblitz.com/edit/vitejs-vite-hawfhb?file=src%2FApp.vue

PrimeVue version

4.0.0-beta.3

Vue version

3.x

Language

ES6

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Click the right-hand button in the reproducer
  2. the form is submitted

Expected behavior

The form should not submit

@butskristof butskristof added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 17, 2024
@m-meier
Copy link
Contributor

m-meier commented May 17, 2024

This is a duplicate of #5700. It will be fixed in rc1

@butskristof
Copy link
Author

Thanks for mentioning @m-meier, I must've missed it when looking through the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants