Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform wrapping html tags to pug #26

Open
Shinigami92 opened this issue Oct 5, 2019 · 4 comments
Open

Transform wrapping html tags to pug #26

Shinigami92 opened this issue Oct 5, 2019 · 4 comments
Labels
help wanted We are looking for community help type: enhancement Functionality that enhances existing features

Comments

@Shinigami92
Copy link
Member

This

<!DOCTYPE html>
<html>

body
  p Indenting the body tag here would make no difference.
  <p>HTML itself isn't whitespace-sensitive.</p>
  ul
    li Item A
    li Item B
    li Item C
  <ul>
    <li>Item A</li>
    li Item B
    <li>Item C</li>
  </ul>

</html>

Should become this

doctype html
html

body
  p Indenting the body tag here would make no difference.
  p HTML itself isn't whitespace-sensitive.
  ul
    li Item A
    li Item B
    li Item C
  ul
    li Item A
    li Item B
    li Item C
@Shinigami92 Shinigami92 added type: enhancement Functionality that enhances existing features help wanted We are looking for community help labels Oct 5, 2019
@Shinigami92
Copy link
Member Author

Followup Issue of #24 (comment)

@Shinigami92
Copy link
Member Author

@lehni Do you also want to work on some of these help wanted issues?

@lehni
Copy link
Collaborator

lehni commented Oct 5, 2020

@Shinigami92 it may be tricky for me to do so right now, as I've got a lot of stuff to tackle at work, and this isn't something we need since we don't mix the two

@Shinigami92
Copy link
Member Author

Occurrences of embedded html tags like b should be kept in mind and observed / tested during implementation

Example:
https://github.com/webkom/vote/blob/6093f437415b921c33d06c35123e9bc83e214c72/app/views/login.pug#L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We are looking for community help type: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lehni @Shinigami92