Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding constants for NPC trade text pointers #500

Closed
SatoMew opened this issue Mar 8, 2025 · 0 comments
Closed

Consider adding constants for NPC trade text pointers #500

SatoMew opened this issue Mar 8, 2025 · 0 comments

Comments

@SatoMew
Copy link
Contributor

SatoMew commented Mar 8, 2025

Proposed by @Narishma-gb in #493 (comment)

Slightly off-topic, would you consider using constants in in_game_trades.asm ? Trade text dialogs are indexed at wInGameTradeTextPointerTableIndex, and are used as raw numbers in DoInGameTradeDialogue.

; in game trade text pointers
; TradeTextPointersX indexes (see engine/events/in_game_trades.asm)
	const_def
	const TEXT_WANNA_TRADE ; 0
	const TEXT_NO_TRADE    ; 1
	const TEXT_WRONG_MON   ; 2
	const TEXT_THANKS      ; 3
	const TEXT_AFTER_TRADE ; 4

I used these constant names in Pokegreen, see https://github.com/Narishma-gb/pokegreen/blob/24ad50fa9c7295e7b2fd003a7b40386cc02a7d32/engine/events/in_game_trades.asm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants