Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document bard music #2053

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Document bard music #2053

wants to merge 4 commits into from
+6,948 −6,841

Conversation

GriffinRichards
Copy link
Member

@GriffinRichards GriffinRichards commented Oct 21, 2024 •
edited
Loading

  • Add missing usage of the constant added in Added define value for bard sound length #2052, and correct a mistaken use of it.
  • Rename BARD_SONG_LENGTH to NUM_BARD_SONG_WORDS to avoid confusion with the length of the song in time.
  • Use EC_WORD_* constants for the remaining bard sound arrays

@GriffinRichards GriffinRichards changed the title Missing bard song limit constants Document bard music Oct 25, 2024
@GriffinRichards
Copy link
Member Author

Went down a rabbit hole, this is now documenting some of the opaque parts of how the Bard NPC's music works, including using the PH_ song constants in the bard music data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GriffinRichards