Define field script opcode constants #2005
Open
+474
−454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the magic number opcodes in field script command macros with these new constants
mrgriffin
requested changes
Jul 9, 2024
Comment on lines
+4
to
+8
| .ifndef ALLOCATE_SCRIPT_CMD_TABLE | ||
| enum \constant | ||
| .else | ||
| .4byte \value | ||
| .endif |
There was a problem hiding this comment.
I think .if/.ifne would be clearer than .ifdef/.ifndef (and are necessary with an explicit .set ALLOCATION_SCRIPT_CMD_TABLE, 0), e.g.:
Suggested change
| .ifndef ALLOCATE_SCRIPT_CMD_TABLE | |
| enum \constant | |
| .else | |
| .4byte \value | |
| .endif | |
| .if ALLOCATE_SCRIPT_CMD_TABLE | |
| .4byte \value | |
| .else | |
| enum \constant | |
| .endif |
| @@ -1,52 +1,54 @@ | |||
| .include "data/script_cmd_table.inc" | |||
There was a problem hiding this comment.
I think it makes sense to be explicit here:
Suggested change
| .include "data/script_cmd_table.inc" | |
| .set ALLOCATE_SCRIPT_CMD_TABLE, 0 | |
| .include "data/script_cmd_table.inc" |
|
|
||
|
|
||
| enum_start | ||
| .ifdef ALLOCATE_SCRIPT_CMD_TABLE |
There was a problem hiding this comment.
Suggested change
| .ifdef ALLOCATE_SCRIPT_CMD_TABLE | |
| .if ALLOCATE_SCRIPT_CMD_TABLE |
|
|
||
| .ifdef ALLOCATE_SCRIPT_CMD_TABLE |
There was a problem hiding this comment.
Suggested change
| .ifdef ALLOCATE_SCRIPT_CMD_TABLE | |
| .if ALLOCATE_SCRIPT_CMD_TABLE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also replace the magic number opcodes in field script command macros with these new constants
Discord contact info
yoshord