Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

battle-anim: fix UB by subtracting by 16 #1839

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

battle-anim: fix UB by subtracting by 16 #1839

wants to merge 1 commit into from
+1 −1

Commits on Jan 6, 2023

  1. battle-anim:fix UB by subtracting by 16 

    The current code follows the nonsensical asm
generated by agbcc, which converted a
subtraction by 16 into an addition by
a halfword value of -16.

This conversion happened at the
portion of the compiler
that does platform-specific transformations.

This code in C is UB,
as it relies on overflowing of a negative value.

Signed-off-by:Arven
    @AreaZeroArven
    AreaZeroArven authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    6a65d8d View commit details
    Browse the repository at this point in the history