docs: Separate java worker only session properties

[pramodsatya]

Presto general session properties in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/admin/properties-session.rst#general-properties contains Java worker only session properties. These should be separated out into another document (ref:JavaWorkerSessionPropertyProvider.java), similar to the one for Presto C++ session properties (https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst).

Additional context

#26348 (comment)

cc: @steveburnett

[steveburnett]

Thanks for opening the issue @pramodsatya!

I think this is a good idea as it aligns with my goal to improve the coverage and organization of the Presto documentation for Presto properties, both session and configuration.

Let me think through this, and I'd like confirmation or correction of my thoughts.

• [Steve] The session properties in General Properties of Presto Session Properties should be separated out to a new file.

  • [Pramod] Only the java worker specific session properties should be separated out to the new file. They can be found here.
  • [Steve] Thanks!

• [Steve] Name the new file "Presto Worker Session Properties (Java only)", or something similar.

  Note: I'm offering a guess for the title based on my understanding of the issue. I'd like a shorter title if possible but it might not be possible without being uselessly vague. I welcome any clarification or improvements offered.

  • [Pramod] Could we name it Presto Java Session Properties, similar to https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst ?
  • [Steve] Sure, we could. I think it might help if a sentence was added at the beginning of the new doc file, and also to the beginning of https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst. Something like "These session properties affect the Presto {Java|C++] worker and do not affect {the other} worker nodes or the Presto coordinator."
    What do you think? Is my suggested statement true for https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst?
  • [Pramod] Yes this is accurate and would be very helpful.

• [Steve] The existing Presto Session Properties should have a cross-reference to the new file.

  • [Pramod] Yes, would be great if the existing Presto session properties can reference to both the Java worker session properties doc (to be added) and the existing C++ worker session properties doc, so the users know what session properties are supported based on the cluster type. What do you think?
  • [Steve] You want cross-reference links added to General Properties that link to both the new file and also https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst? Sure, we could probably do that.

  [Steve] I'd probably keep the heading General Properties, and replace the contents with "See [link to new file]."

  • [Pramod] Sounds good!
  • [Steve] Revised to "See [link to new file] and [link to Presto C++ Session Properties]."

Questions:

1. [Steve] Are only - and all - the properties in General Properties to be moved to the new file?

   • [Pramod] Replied earlier.

2. [Steve] Are there any other properties in Presto Session Properties not in General Properties that should be moved to the new file?

   • [Pramod] If there is any new java worker session property that is not documented currently in Presto General Session Properties, they should be moved too.

3. [Steve] Is similar work appropriate to plan for Presto Configuration Properties?
   If "Yes", then I recommend a new issue with its own PR, instead of enlarging the scope of this one.

   • [Pramod] No this is needed only for session properties.

[pramodsatya]

Thanks @steveburnett, replied inline to the points. Please let me know what you think and if you have any further questions.

[steveburnett]

Thanks @steveburnett, replied inline to the points. Please let me know what you think and if you have any further questions.

@pramodsatya thanks for the replies! When I started to reply to your replies it looked confusing to me, so I added our names before our entries hoping it would be easier to read.

My new replies are also inline.

[pramodsatya]

Thanks @steveburnett, the list looks good to me.