[Native] Advance Velox

Author: aditi-pandit

presto-native-execution/velox

@@ -59,6 +59,7 @@
 import static com.facebook.presto.common.type.StandardTypes.ROW;
 import static com.facebook.presto.common.type.StandardTypes.SMALLINT;
 import static com.facebook.presto.common.type.StandardTypes.TDIGEST;
+import static com.facebook.presto.common.type.StandardTypes.TIME;
 import static com.facebook.presto.common.type.StandardTypes.TIMESTAMP;
 import static com.facebook.presto.common.type.StandardTypes.TIMESTAMP_WITH_TIME_ZONE;
 import static com.facebook.presto.common.type.StandardTypes.TINYINT;
@@ -84,6 +85,7 @@ public class NativeTypeManager
                     TINYINT,
                     BOOLEAN,
                     DATE,
+                    TIME,
                     INTEGER,
                     DOUBLE,
                     SMALLINT,

presto-native-sidecar-plugin/src/main/java/com/facebook/presto/sidecar/typemanager/NativeTypeManager.java

@@ -36,7 +36,7 @@ public void init(String storageFormat, boolean charNToVarcharImplicitCast, boole
         if (sidecarEnabled) {
             charTypeUnsupportedError = ".*Unknown type: char.*";
             timeTypeUnsupportedError = ".*Unknown type: time.*";
-            approxDistinctUnsupportedSignatureError = ".*Unexpected parameters \\(timestamp with time zone.*\\) for function.*";
+            approxDistinctUnsupportedSignatureError = ".*Unexpected parameters \\(time.*\\) for function.*";
         }
         else {
             charTypeUnsupportedError = "Failed to parse type.*char";
@@ -75,8 +75,8 @@ public void testApproximateCountDistinct()
                 approxDistinctUnsupportedSignatureError, true);
 
         // test time
-        assertQueryFails("SELECT approx_distinct(CAST(from_unixtime(custkey) AS TIME)) FROM orders", timeTypeUnsupportedError, true);
-        assertQueryFails("SELECT approx_distinct(CAST(from_unixtime(custkey) AS TIME), 0.023) FROM orders", timeTypeUnsupportedError, true);
+        assertQueryFails("SELECT approx_distinct(CAST(from_unixtime(custkey) AS TIME)) FROM orders", approxDistinctUnsupportedSignatureError, true);
+        assertQueryFails("SELECT approx_distinct(CAST(from_unixtime(custkey) AS TIME), 0.023) FROM orders", approxDistinctUnsupportedSignatureError, true);
 
         // test time with time zone
         assertQueryFails("SELECT approx_distinct(CAST(from_unixtime(custkey) AS TIME WITH TIME ZONE)) FROM orders", timeTypeUnsupportedError, true);

presto-native-tests/src/test/java/com/facebook/presto/nativetests/AbstractTestAggregationsNative.java

@@ -15,17 +15,13 @@
 
 import com.facebook.presto.testing.QueryRunner;
 import com.facebook.presto.tests.AbstractTestEngineOnlyQueries;
-import org.intellij.lang.annotations.Language;
 import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
-import java.time.LocalDate;
 import java.time.LocalTime;
-import java.time.ZoneId;
-import java.time.format.DateTimeFormatter;
 
-import static com.google.common.base.Preconditions.checkState;
 import static java.lang.Boolean.parseBoolean;
+import static org.testng.Assert.assertEquals;
 
 public class TestDistributedEngineOnlyQueries
         extends AbstractTestEngineOnlyQueries
@@ -68,10 +64,10 @@ protected void createTables()
     @Test
     public void testTimeLiterals()
     {
-        assertQueryFails("SELECT TIME '3:04:05'", timeTypeUnsupportedError);
-        assertQueryFails("SELECT TIME '3:04:05.123'", timeTypeUnsupportedError);
-        assertQueryFails("SELECT TIME '3:04:05'", timeTypeUnsupportedError);
-        assertQueryFails("SELECT TIME '0:04:05'", timeTypeUnsupportedError);
+        assertEquals(computeScalar("SELECT TIME '3:04:05'"), LocalTime.of(3, 4, 5, 0));
+        assertEquals(computeScalar("SELECT TIME '3:04:05.123'"), LocalTime.of(3, 4, 5, 123_000_000));
+        assertQuery("SELECT TIME '3:04:05'");
+        assertQuery("SELECT TIME '0:04:05'");
         // TODO #7122 assertQueryFails(chicago, "SELECT TIME '3:04:05'", timeTypeUnsupportedError);
         // TODO #7122 assertQueryFails(kathmandu, "SELECT TIME '3:04:05'", timeTypeUnsupportedError);
 
@@ -82,17 +78,6 @@ public void testTimeLiterals()
         assertQueryFails("SELECT TIME '3:04:05 +03'", timeTypeUnsupportedError);
     }
 
-    /// TIME datatype is not supported in Prestissimo. See issue: https://github.com/prestodb/presto/issues/18844.
-    @Override
-    @Test
-    public void testLocallyUnrepresentableTimeLiterals()
-    {
-        LocalTime localTimeThatDidNotOccurOn20120401 = LocalTime.of(2, 10);
-        checkState(ZoneId.systemDefault().getRules().getValidOffsets(localTimeThatDidNotOccurOn20120401.atDate(LocalDate.of(2012, 4, 1))).isEmpty(), "This test assumes certain JVM time zone");
-        @Language("SQL") String sql = DateTimeFormatter.ofPattern("'SELECT TIME '''HH:mm:ss''").format(localTimeThatDidNotOccurOn20120401);
-        assertQueryFails(sql, timeTypeUnsupportedError);
-    }
-
     // todo: turn on these test cases when the sql invoked functions are extracted into a plugin module.
     @Override
     @Test(enabled = false)