Fix errors by pre-commit

Author: unidevel

.github/workflows/publish-docker-images.yml

@@ -91,6 +91,9 @@ env:
   NATIVE_IMAGE_NAME: presto-native
   DEPENDENCY_IMAGE_NAME: presto-native-dependency
   TAG_SUFFIX: ${{ inputs.tag_suffix }}
+  INPUT_OS: ${{ inputs.os }}
+  INPUT_TAG_LATEST: ${{ inputs.tag_latest }}
+  INPUT_PUBLISH_DEPENDENCY: ${{ inputs.publish_dependency }}
 
 jobs:
   prepare:
@@ -209,10 +212,10 @@ jobs:
 
       - name: Set image tag
         run: |
-          TAG_BASE="${{ env.ORG_NAME }}/${{ env.DEPENDENCY_IMAGE_NAME }}:${{ inputs.os }}-${{ env.VERSION }}-${{ matrix.arch }}"
+          TAG_BASE="${{ env.ORG_NAME }}/${{ env.DEPENDENCY_IMAGE_NAME }}:${INPUT_OS}-${{ env.VERSION }}-${{ matrix.arch }}"
           echo "IMAGE_TAG=${TAG_BASE}${TAG_SUFFIX}" >> $GITHUB_ENV
 
-          if [[ "${{ inputs.os }}" == "ubuntu" ]]; then
+          if [[ "${INPUT_OS}" == "ubuntu" ]]; then
             echo "DEPENDENCY_TARGET=ubuntu-native-dependency" >> $GITHUB_ENV
             echo "LOCAL_IMAGE_TAG=presto/prestissimo-dependency:ubuntu-22.04" >> $GITHUB_ENV
           else
@@ -244,8 +247,8 @@ jobs:
           docker tag ${{ env.LOCAL_IMAGE_TAG }} ${{ env.IMAGE_TAG }}
           docker push ${{ env.IMAGE_TAG }}
 
-          if [[ "${{ inputs.tag_latest }}" == "true" ]]; then
-            LATEST_TAG="${{ env.ORG_NAME }}/${{ env.DEPENDENCY_IMAGE_NAME }}:${{ inputs.os }}-${{ matrix.arch }}-latest"
+          if [[ "${INPUT_TAG_LATEST}" == "true" ]]; then
+            LATEST_TAG="${{ env.ORG_NAME }}/${{ env.DEPENDENCY_IMAGE_NAME }}:${INPUT_OS}-${{ matrix.arch }}-latest"
             docker tag ${{ env.LOCAL_IMAGE_TAG }} ${LATEST_TAG}
             docker push ${LATEST_TAG}
             echo "Tagged and pushed as latest: ${LATEST_TAG}"
@@ -289,7 +292,7 @@ jobs:
           docker manifest push ${MANIFEST_TAG}
 
           # Create latest manifest if requested
-          if [[ "${{ inputs.tag_latest }}" == "true" ]]; then
+          if [[ "${INPUT_TAG_LATEST}" == "true" ]]; then
             # Create OS-specific latest manifest
             LATEST_MANIFEST="${ORG_NAME}/${IMAGE_NAME}:${OS}-latest"
             LATEST_AMD64="${ORG_NAME}/${IMAGE_NAME}:${OS}-amd64-latest"
@@ -320,7 +323,7 @@ jobs:
     steps:
       - name: Check OS compatibility
         run: |
-          if [[ "${{ inputs.os }}" == "ubuntu" ]]; then
+          if [[ "${INPUT_OS}" == "ubuntu" ]]; then
             echo "::error::Presto Docker image is only supported for CentOS. Ubuntu is not supported for the Presto server image."
             exit 1
           fi
@@ -465,30 +468,30 @@ jobs:
 
       - name: Set image tag and base image
         run: |
-          TAG_BASE="${{ env.ORG_NAME }}/${{ env.NATIVE_IMAGE_NAME }}:${{ inputs.os }}-${{ env.VERSION }}-${{ matrix.arch }}"
+          TAG_BASE="${{ env.ORG_NAME }}/${{ env.NATIVE_IMAGE_NAME }}:${INPUT_OS}-${{ env.VERSION }}-${{ matrix.arch }}"
           echo "IMAGE_TAG=${TAG_BASE}${TAG_SUFFIX}" >> $GITHUB_ENV
 
-          if [[ "${{ inputs.os }}" == "ubuntu" ]]; then
+          if [[ "${INPUT_OS}" == "ubuntu" ]]; then
             echo "BASE_IMAGE=ubuntu:22.04" >> $GITHUB_ENV
           else
             echo "BASE_IMAGE=quay.io/centos/centos:stream9" >> $GITHUB_ENV
           fi
 
           # Set dependency image based on whether we built it or need to use latest from dockerhub
-          if [[ "${{ inputs.publish_dependency }}" == "true" ]]; then
+          if [[ "${INPUT_PUBLISH_DEPENDENCY}" == "true" ]]; then
             # Use the dependency image we just built
-            DEPENDENCY_IMAGE="${{ env.ORG_NAME }}/presto-native-dependency:${{ inputs.os }}-${{ env.VERSION }}-${{ matrix.arch }}${TAG_SUFFIX}"
+            DEPENDENCY_IMAGE="${{ env.ORG_NAME }}/presto-native-dependency:${INPUT_OS}-${{ env.VERSION }}-${{ matrix.arch }}${TAG_SUFFIX}"
           else
             # Use the latest dependency image from dockerhub
-            if [[ "${OS}" == "centos" ]]; then
+            if [[ "${INPUT_OS}" == "centos" ]]; then
               DEPENDENCY_IMAGE="${{ env.ORG_NAME }}/presto-native-dependency:${{ matrix.arch }}-latest"
             else
-              DEPENDENCY_IMAGE="${{ env.ORG_NAME }}/presto-native-dependency:${{ inputs.os }}-${{ matrix.arch }}-latest"
+              DEPENDENCY_IMAGE="${{ env.ORG_NAME }}/presto-native-dependency:${INPUT_OS}-${{ matrix.arch }}-latest"
             fi
           fi
           echo "DEPENDENCY_IMAGE=${DEPENDENCY_IMAGE}" >> $GITHUB_ENV
 
-          if [[ "${{ inputs.os }}" == "ubuntu" ]]; then
+          if [[ "${INPUT_OS}" == "ubuntu" ]]; then
             LOCAL_IMAGE_TAG="presto/prestissimo-dependency:ubuntu-22.04"
           else
             LOCAL_IMAGE_TAG="presto/prestissimo-dependency:centos9"
@@ -512,7 +515,7 @@ jobs:
             -DPRESTO_ENABLE_SPATIAL=ON \
             -DPRESTO_ENABLE_TESTING=OFF \
             -DPRESTO_ENABLE_S3=ON"
-          if [[ "${{ inputs.os }}" == "ubuntu" ]]; then
+          if [[ "${INPUT_OS}" == "ubuntu" ]]; then
             EXTRA_CMAKE_FLAGS="$EXTRA_CMAKE_FLAGS -DCMAKE_CXX_FLAGS='-Wno-error=stringop-overflow -Wno-psabi'"
           fi
           if [[ "${{ matrix.arch }}" == "arm64-generic" ]]; then
@@ -526,7 +529,7 @@ jobs:
             --build-arg EXTRA_CMAKE_FLAGS="$EXTRA_CMAKE_FLAGS" \
             --build-arg DEPENDENCY_IMAGE=${{ env.DEPENDENCY_IMAGE }} \
             --build-arg BASE_IMAGE=$BASE_IMAGE \
-            --build-arg OSNAME=${{ inputs.os }} \
+            --build-arg OSNAME=${INPUT_OS} \
             --build-arg BUILD_TYPE=Release \
             --build-arg NUM_THREADS=2 \
             ${BUILD_ARGS} \
@@ -539,8 +542,8 @@ jobs:
           set -e
           docker push ${{ env.IMAGE_TAG }}
 
-          if [[ "${{ inputs.tag_latest }}" == "true" ]]; then
-            LATEST_TAG="${{ env.ORG_NAME }}/${{ env.NATIVE_IMAGE_NAME }}:${{ inputs.os }}-${{ matrix.arch }}-latest"
+          if [[ "${INPUT_TAG_LATEST}" == "true" ]]; then
+            LATEST_TAG="${{ env.ORG_NAME }}/${{ env.NATIVE_IMAGE_NAME }}:${INPUT_OS}-${{ matrix.arch }}-latest"
             docker tag ${{ env.IMAGE_TAG }} ${LATEST_TAG}
             docker push ${LATEST_TAG}
             echo "Tagged and pushed as latest: ${LATEST_TAG}"
@@ -584,7 +587,7 @@ jobs:
           docker manifest push ${MANIFEST_TAG}
 
           # Create latest manifest if requested
-          if [[ "${{ inputs.tag_latest }}" == "true" ]]; then
+          if [[ "${INPUT_TAG_LATEST}" == "true" ]]; then
             # Create OS-specific latest manifest
             LATEST_MANIFEST="${ORG_NAME}/${IMAGE_NAME}:${OS}-latest"
             LATEST_AMD64="${ORG_NAME}/${IMAGE_NAME}:${OS}-amd64-latest"