Address comments

Use `StandardTypes` to check the type of the procedure arguments

Throw a `PrestoException` with error code of `INVALID_ARGUMENTS` rather than an IAE

Author: hantangwangd

presto-spi/src/main/java/com/facebook/presto/spi/procedure/BaseProcedure.java

@@ -14,6 +14,7 @@
 package com.facebook.presto.spi.procedure;
 
 import com.facebook.presto.common.type.TypeSignature;
+import com.facebook.presto.spi.PrestoException;
 import jakarta.annotation.Nullable;
 
 import java.util.ArrayList;
@@ -22,6 +23,7 @@
 import java.util.Set;
 
 import static com.facebook.presto.common.type.TypeSignature.parseTypeSignature;
+import static com.facebook.presto.spi.StandardErrorCode.INVALID_ARGUMENTS;
 import static java.lang.String.format;
 import static java.util.Collections.unmodifiableList;
 import static java.util.Locale.ENGLISH;
@@ -150,7 +152,7 @@ private static String checkNotNullOrEmpty(String value, String name)
     protected static void checkArgument(boolean assertion, String message)
     {
         if (!assertion) {
-            throw new IllegalArgumentException(message);
+            throw new PrestoException(INVALID_ARGUMENTS, message);
         }
     }
 }

presto-spi/src/main/java/com/facebook/presto/spi/procedure/TableDataRewriteDistributedProcedure.java

@@ -24,6 +24,7 @@
 import java.util.OptionalInt;
 import java.util.function.Supplier;
 
+import static com.facebook.presto.common.type.StandardTypes.VARCHAR;
 import static com.facebook.presto.spi.procedure.DistributedProcedure.DistributedProcedureType.TABLE_DATA_REWRITE;
 import static java.lang.String.format;
 import static java.util.Objects.requireNonNull;
@@ -54,12 +55,12 @@ public TableDataRewriteDistributedProcedure(String schema, String name,
         this.contextSupplier = requireNonNull(contextSupplier, "contextSupplier is null");
         for (int i = 0; i < getArguments().size(); i++) {
             if (getArguments().get(i).getName().equals(SCHEMA)) {
-                checkArgument(getArguments().get(i).getType().toString().equalsIgnoreCase("varchar"),
+                checkArgument(getArguments().get(i).getType().getBase().equals(VARCHAR),
                         format("Argument `%s` must be string type", SCHEMA));
                 schemaIndex = i;
             }
             else if (getArguments().get(i).getName().equals(TABLE_NAME)) {
-                checkArgument(getArguments().get(i).getType().toString().equalsIgnoreCase("varchar"),
+                checkArgument(getArguments().get(i).getType().getBase().equals(VARCHAR),
                         format("Argument `%s` must be string type", TABLE_NAME));
                 tableNameIndex = i;
             }