Skip to content

Commit 694bfa3

Browse files
authored
fix(ci): Check format for workflow yml files (#26473)
The format checker is not called when yml files in the github workflow are modified but none in presto-native-execution. Thus, skipping changes that are found to be incorrect when the format check is called on the next PR. ## Description <!---Describe your changes in detail--> ## Motivation and Context <!---Why is this change required? What problem does it solve?--> <!---If it fixes an open issue, please link to the issue here.--> ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == NO RELEASE NOTE == ```
1 parent 6a51bc1 commit 694bfa3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/jdbc-connector-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,4 @@ jobs:
6464
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl :presto-mysql,:presto-postgresql
6565
- name: Run MySQL and PostgreSQL Tests
6666
if: needs.changes.outputs.codechange == 'true'
67-
run: ./mvnw test ${MAVEN_TEST} -P ci -pl :presto-mysql,:presto-postgresql
67+
run: ./mvnw test ${MAVEN_TEST} -P ci -pl :presto-mysql,:presto-postgresql

.github/workflows/prestocpp-format-and-header-check.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ on:
55
pull_request:
66
paths:
77
- presto-native-execution/**
8-
- .github/workflows/prestocpp-format-and-header-check.yml
8+
- .github/workflows/*.yml
99

1010
jobs:
1111
prestocpp-format-and-header-check:
@@ -18,6 +18,6 @@ jobs:
1818
steps:
1919
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
2020
with:
21-
persist-credentials: false
21+
persist-credentials: true
2222
- uses: actions/setup-python@3542bca2639a428e1796aaa6a2ffef0c0f575566 # v3.1.4
2323
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1

0 commit comments

Comments
 (0)