Add DROP TAG sql support

Author: agrawalreetika

presto-analyzer/src/main/java/com/facebook/presto/sql/analyzer/utils/StatementUtils.java

@@ -41,6 +41,7 @@
 import com.facebook.presto.sql.tree.DropRole;
 import com.facebook.presto.sql.tree.DropSchema;
 import com.facebook.presto.sql.tree.DropTable;
+import com.facebook.presto.sql.tree.DropTag;
 import com.facebook.presto.sql.tree.DropView;
 import com.facebook.presto.sql.tree.Explain;
 import com.facebook.presto.sql.tree.Grant;
@@ -133,6 +134,7 @@ private StatementUtils() {}
         builder.put(DropColumn.class, QueryType.DATA_DEFINITION);
         builder.put(DropTable.class, QueryType.DATA_DEFINITION);
         builder.put(DropBranch.class, QueryType.DATA_DEFINITION);
+        builder.put(DropTag.class, QueryType.DATA_DEFINITION);
         builder.put(DropConstraint.class, QueryType.DATA_DEFINITION);
         builder.put(AddConstraint.class, QueryType.DATA_DEFINITION);
         builder.put(AlterColumnNotNull.class, QueryType.DATA_DEFINITION);

presto-docs/src/main/sphinx/sql/alter-table.rst

@@ -16,6 +16,7 @@ Synopsis
     ALTER TABLE [ IF EXISTS ] name ALTER [ COLUMN ] column_name { SET | DROP } NOT NULL
     ALTER TABLE [ IF EXISTS ] name SET PROPERTIES (property_name=value, [, ...])
     ALTER TABLE [ IF EXISTS ] name DROP BRANCH [ IF EXISTS ] branch_name
+    ALTER TABLE [ IF EXISTS ] name DROP TAG [ IF EXISTS ] tag_name
 
 Description
 -----------
@@ -99,6 +100,10 @@ Drop branch ``branch1`` from the ``users`` table::
 
     ALTER TABLE users DROP BRANCH 'branch1';
 
+Drop tag ``tag1`` from the ``users`` table::
+
+    ALTER TABLE users DROP TAG 'tag1';
+
 See Also
 --------
 

presto-hive/src/main/java/com/facebook/presto/hive/security/LegacyAccessControl.java

@@ -281,6 +281,11 @@ public void checkCanDropBranch(ConnectorTransactionHandle transactionHandle, Con
     {
     }
 
+    @Override
+    public void checkCanDropTag(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName)
+    {
+    }
+
     @Override
     public void checkCanDropConstraint(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName)
     {

presto-hive/src/main/java/com/facebook/presto/hive/security/SqlStandardAccessControl.java

@@ -69,6 +69,7 @@
 import static com.facebook.presto.spi.security.AccessDeniedException.denyDropRole;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyDropSchema;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyDropTable;
+import static com.facebook.presto.spi.security.AccessDeniedException.denyDropTag;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyDropView;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyGrantRoles;
 import static com.facebook.presto.spi.security.AccessDeniedException.denyGrantTablePrivilege;
@@ -314,6 +315,24 @@ public void checkCanDropBranch(ConnectorTransactionHandle transaction, Connector
         }
     }
 
+    @Override
+    public void checkCanDropTag(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName)
+    {
+        MetastoreContext metastoreContext = new MetastoreContext(
+                identity, context.getQueryId().getId(),
+                context.getClientInfo(),
+                context.getClientTags(),
+                context.getSource(),
+                Optional.empty(),
+                false,
+                HiveColumnConverterProvider.DEFAULT_COLUMN_CONVERTER_PROVIDER,
+                context.getWarningCollector(),
+                context.getRuntimeStats());
+        if (!isTableOwner(transaction, identity, metastoreContext, tableName)) {
+            denyDropTag(tableName.toString());
+        }
+    }
+
     @Override
     public void checkCanDropConstraint(ConnectorTransactionHandle transaction, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName)
     {

presto-hive/src/main/java/com/facebook/presto/hive/security/SystemTableAwareAccessControl.java

@@ -263,6 +263,12 @@ public void checkCanDropBranch(ConnectorTransactionHandle transactionHandle, Con
         delegate.checkCanDropBranch(transactionHandle, identity, context, tableName);
     }
 
+    @Override
+    public void checkCanDropTag(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName)
+    {
+        delegate.checkCanDropTag(transactionHandle, identity, context, tableName);
+    }
+
     @Override
     public void checkCanDropConstraint(ConnectorTransactionHandle transactionHandle, ConnectorIdentity identity, AccessControlContext context, SchemaTableName tableName)
     {

presto-main-base/src/main/java/com/facebook/presto/metadata/DelegatingMetadataManager.java

@@ -643,6 +643,12 @@ public void dropBranch(Session session, TableHandle tableHandle, String branchNa
         delegate.dropBranch(session, tableHandle, branchName, branchExists);
     }
 
+    @Override
+    public void dropTag(Session session, TableHandle tableHandle, String tagName, boolean tagExists)
+    {
+        delegate.dropTag(session, tableHandle, tagName, tagExists);
+    }
+
     @Override
     public void dropConstraint(Session session, TableHandle tableHandle, Optional<String> constraintName, Optional<String> columnName)
     {

presto-main-base/src/main/java/com/facebook/presto/metadata/Metadata.java

@@ -524,6 +524,8 @@ default TableLayoutFilterCoverage getTableLayoutFilterCoverage(Session session,
 
     void dropBranch(Session session, TableHandle tableHandle, String branchName, boolean branchExists);
 
+    void dropTag(Session session, TableHandle tableHandle, String tagName, boolean tagExists);
+
     void dropConstraint(Session session, TableHandle tableHandle, Optional<String> constraintName, Optional<String> columnName);
 
     void addConstraint(Session session, TableHandle tableHandle, TableConstraint<String> tableConstraint);

presto-main-base/src/main/java/com/facebook/presto/metadata/MetadataManager.java

@@ -1471,6 +1471,14 @@ public void dropBranch(Session session, TableHandle tableHandle, String branchNa
         metadata.dropBranch(session.toConnectorSession(connectorId), tableHandle.getConnectorHandle(), branchName, branchExists);
     }
 
+    @Override
+    public void dropTag(Session session, TableHandle tableHandle, String tagName, boolean tagExists)
+    {
+        ConnectorId connectorId = tableHandle.getConnectorId();
+        ConnectorMetadata metadata = getMetadataForWrite(session, connectorId);
+        metadata.dropTag(session.toConnectorSession(connectorId), tableHandle.getConnectorHandle(), tagName, tagExists);
+    }
+
     @Override
     public void dropConstraint(Session session, TableHandle tableHandle, Optional<String> constraintName, Optional<String> columnName)
     {

presto-main-base/src/main/java/com/facebook/presto/security/AccessControlManager.java

@@ -786,6 +786,22 @@ public void checkCanDropBranch(TransactionId transactionId, Identity identity, A
         }
     }
 
+    @Override
+    public void checkCanDropTag(TransactionId transactionId, Identity identity, AccessControlContext context, QualifiedObjectName tableName)
+    {
+        requireNonNull(identity, "identity is null");
+        requireNonNull(tableName, "tableName is null");
+
+        authenticationCheck(() -> checkCanAccessCatalog(identity, context, tableName.getCatalogName()));
+
+        authorizationCheck(() -> systemAccessControl.get().checkCanDropTag(identity, context, toCatalogSchemaTableName(tableName)));
+
+        CatalogAccessControlEntry entry = getConnectorAccessControl(transactionId, tableName.getCatalogName());
+        if (entry != null) {
+            authorizationCheck(() -> entry.getAccessControl().checkCanDropTag(entry.getTransactionHandle(transactionId), identity.toConnectorIdentity(tableName.getCatalogName()), context, toSchemaTableName(tableName)));
+        }
+    }
+
     @Override
     public void checkCanDropConstraint(TransactionId transactionId, Identity identity, AccessControlContext context, QualifiedObjectName tableName)
     {

presto-main-base/src/main/java/com/facebook/presto/security/AllowAllSystemAccessControl.java

@@ -231,6 +231,11 @@ public void checkCanDropBranch(Identity identity, AccessControlContext context,
     {
     }
 
+    @Override
+    public void checkCanDropTag(Identity identity, AccessControlContext context, CatalogSchemaTableName table)
+    {
+    }
+
     @Override
     public void checkCanDropConstraint(Identity identity, AccessControlContext context, CatalogSchemaTableName table)
     {