Skip to content

Commit 4054ff7

Browse files
fix(deps): Fix CVE-2025-48924: Replace commons-lang with commons-lang3:3.18.0 (#26248)
## Description - Fix CVE-2025-48924: Upgrade calcite-core in presto-pinot as calcite-core:1.38.0 brought in commons-lang:2.4 transitively. - Replaced the vulnerable commons-lang dependency with commons-lang3 in presto-accumulo ## Motivation and Context Commons-lang 2.x is end-of-life (last version 2.6, released 2011) and no longer receives security updates. It has been replaced by commons-lang3. This PR moves the project to use commons-lang3 instead. ## Impact <!---Describe any public API or user-facing feature change or any performance impact--> ## Test Plan <!---Please fill in how you tested your change--> ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes Please follow [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines) and fill in the release notes below. ``` == RELEASE NOTES == Security Changes * Upgrade calcite-core to 1.41.0 in response to `CVE-2025-48924 <https://github.com/advisories/GHSA-j288-q9x7-2f5v>`_. ```
1 parent f5318c3 commit 4054ff7

File tree

5 files changed

+4
-10
lines changed

5 files changed

+4
-10
lines changed

presto-accumulo/pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,6 @@
232232
<artifactId>guice</artifactId>
233233
</dependency>
234234

235-
<dependency>
236-
<groupId>commons-lang</groupId>
237-
<artifactId>commons-lang</artifactId>
238-
<version>2.6</version>
239-
</dependency>
240-
241235
<dependency>
242236
<groupId>org.apache.commons</groupId>
243237
<artifactId>commons-lang3</artifactId>

presto-accumulo/src/main/java/com/facebook/presto/accumulo/index/Indexer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
import org.apache.accumulo.core.iterators.user.SummingCombiner;
4747
import org.apache.accumulo.core.security.Authorizations;
4848
import org.apache.accumulo.core.security.ColumnVisibility;
49-
import org.apache.commons.lang.ArrayUtils;
49+
import org.apache.commons.lang3.ArrayUtils;
5050
import org.apache.commons.lang3.tuple.Pair;
5151
import org.apache.hadoop.io.Text;
5252

presto-accumulo/src/main/java/com/facebook/presto/accumulo/io/AccumuloRecordCursor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import org.apache.accumulo.core.data.Value;
3131
import org.apache.accumulo.core.iterators.FirstEntryInRowIterator;
3232
import org.apache.accumulo.core.iterators.user.WholeRowIterator;
33-
import org.apache.commons.lang.StringUtils;
33+
import org.apache.commons.lang3.StringUtils;
3434
import org.apache.hadoop.io.Text;
3535

3636
import java.io.IOException;

presto-accumulo/src/main/java/com/facebook/presto/accumulo/model/Row.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import com.google.common.base.Splitter;
2222
import com.google.common.collect.ImmutableList;
2323
import com.google.common.collect.ImmutableMap;
24-
import org.apache.commons.lang.StringUtils;
24+
import org.apache.commons.lang3.StringUtils;
2525

2626
import java.sql.Date;
2727
import java.sql.Time;

presto-pinot-toolkit/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
<properties>
1616
<air.main.basedir>${project.parent.basedir}</air.main.basedir>
17-
<dep.calcite.version>1.38.0</dep.calcite.version>
17+
<dep.calcite.version>1.41.0</dep.calcite.version>
1818
<project.build.targetJdk>17</project.build.targetJdk>
1919
<air.check.skip-modernizer>true</air.check.skip-modernizer>
2020
<dep.jts.version>1.20.0</dep.jts.version>

0 commit comments

Comments
 (0)