Skip to content

Commit 1207da6

Browse files
xin-zhang2xin-zhang2
committed
Rename ImplementTableFunctionSource to TransformTableFunctionToTableFunctionProcessor
1 parent f5e5c48 commit 1207da6

File tree

4 files changed

+25
-25
lines changed

4 files changed

+25
-25
lines changed

‎presto-main-base/src/main/java/com/facebook/presto/sql/planner/PlanOptimizers.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
import com.facebook.presto.sql.planner.iterative.rule.ImplementBernoulliSampleAsFilter;
5151
import com.facebook.presto.sql.planner.iterative.rule.ImplementFilteredAggregations;
5252
import com.facebook.presto.sql.planner.iterative.rule.ImplementOffset;
53-
import com.facebook.presto.sql.planner.iterative.rule.ImplementTableFunctionSource;
5453
import com.facebook.presto.sql.planner.iterative.rule.InlineProjections;
5554
import com.facebook.presto.sql.planner.iterative.rule.InlineProjectionsOnValues;
5655
import com.facebook.presto.sql.planner.iterative.rule.InlineSqlFunctions;
@@ -157,6 +156,7 @@
157156
import com.facebook.presto.sql.planner.iterative.rule.TransformDistinctInnerJoinToLeftEarlyOutJoin;
158157
import com.facebook.presto.sql.planner.iterative.rule.TransformDistinctInnerJoinToRightEarlyOutJoin;
159158
import com.facebook.presto.sql.planner.iterative.rule.TransformExistsApplyToLateralNode;
159+
import com.facebook.presto.sql.planner.iterative.rule.TransformTableFunctionToTableFunctionProcessor;
160160
import com.facebook.presto.sql.planner.iterative.rule.TransformUncorrelatedInPredicateSubqueryToDistinctInnerJoin;
161161
import com.facebook.presto.sql.planner.iterative.rule.TransformUncorrelatedInPredicateSubqueryToSemiJoin;
162162
import com.facebook.presto.sql.planner.iterative.rule.TransformUncorrelatedLateralToJoin;
@@ -432,7 +432,7 @@ public PlanOptimizers(
432432
.addAll(predicatePushDownRules)
433433
.addAll(columnPruningRules)
434434
.addAll(ImmutableSet.of(
435-
new ImplementTableFunctionSource(metadata),
435+
new TransformTableFunctionToTableFunctionProcessor(metadata),
436436
new MergeDuplicateAggregation(metadata.getFunctionAndTypeManager()),
437437
new RemoveRedundantIdentityProjections(),
438438
new RemoveFullSample(),

‎presto-main-base/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ImplementTableFunctionSource.java‎ renamed to ‎presto-main-base/src/main/java/com/facebook/presto/sql/planner/iterative/rule/TransformTableFunctionToTableFunctionProcessor.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
* - source T2(a2, b2)
132132
* </pre>
133133
*/
134-
public class ImplementTableFunctionSource
134+
public class TransformTableFunctionToTableFunctionProcessor
135135
implements Rule<TableFunctionNode>
136136
{
137137
private static final Pattern<TableFunctionNode> PATTERN = tableFunction();
@@ -149,7 +149,7 @@ public class ImplementTableFunctionSource
149149

150150
private final Metadata metadata;
151151

152-
public ImplementTableFunctionSource(Metadata metadata)
152+
public TransformTableFunctionToTableFunctionProcessor(Metadata metadata)
153153
{
154154
this.metadata = requireNonNull(metadata, "metadata is null");
155155
}

‎presto-main-base/src/main/java/com/facebook/presto/sql/planner/plan/TableFunctionProcessorNode.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public class TableFunctionProcessorNode
7575
// 2 | 40 6 | 100
7676
// 2 | 50 6 | 110
7777
//
78-
// ImplementTableFunctionSource creates a join that produces a cartesian product of partitions from each table, resulting in 4 partitions:
78+
// TransformTableFunctionToTableFunctionProcessor creates a join that produces a cartesian product of partitions from each table, resulting in 4 partitions:
7979
//
8080
// Partition (a=1, c=5):
8181
// a | b | marker_1 | c | d | marker_2

‎presto-main-base/src/test/java/com/facebook/presto/sql/planner/iterative/rule/TestImplementTableFunctionSource.java‎ renamed to ‎presto-main-base/src/test/java/com/facebook/presto/sql/planner/iterative/rule/TestTransformTableFunctionToTableFunctionProcessor.java‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@
4444
import static com.facebook.presto.sql.planner.assertions.PlanMatchPattern.window;
4545
import static com.facebook.presto.sql.planner.plan.TableFunctionNode.PassThroughColumn;
4646

47-
public class TestImplementTableFunctionSource
47+
public class TestTransformTableFunctionToTableFunctionProcessor
4848
extends BaseRuleTest
4949
{
5050
@Test
5151
public void testNoSources()
5252
{
53-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
53+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
5454
.on(p -> p.tableFunction(
5555
"test_function",
5656
ImmutableList.of(p.variable("a")),
@@ -66,7 +66,7 @@ public void testNoSources()
6666
public void testSingleSourceWithRowSemantics()
6767
{
6868
// no pass-through columns
69-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
69+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
7070
.on(p -> {
7171
VariableReferenceExpression a = p.variable("a");
7272
VariableReferenceExpression b = p.variable("b");
@@ -92,7 +92,7 @@ public void testSingleSourceWithRowSemantics()
9292
values("c")));
9393

9494
// pass-through columns
95-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
95+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
9696
.on(p -> {
9797
VariableReferenceExpression a = p.variable("a");
9898
VariableReferenceExpression b = p.variable("b");
@@ -122,7 +122,7 @@ public void testSingleSourceWithRowSemantics()
122122
public void testSingleSourceWithSetSemantics()
123123
{
124124
// no pass-through columns, no partition by
125-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
125+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
126126
.on(p -> {
127127
VariableReferenceExpression a = p.variable("a");
128128
VariableReferenceExpression b = p.variable("b");
@@ -150,7 +150,7 @@ public void testSingleSourceWithSetSemantics()
150150
values("c", "d")));
151151

152152
// no pass-through columns, partitioning column present
153-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
153+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
154154
.on(p -> {
155155
VariableReferenceExpression a = p.variable("a");
156156
VariableReferenceExpression b = p.variable("b");
@@ -178,7 +178,7 @@ public void testSingleSourceWithSetSemantics()
178178
values("c", "d")));
179179

180180
// pass-through columns
181-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
181+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
182182
.on(p -> {
183183
VariableReferenceExpression a = p.variable("a");
184184
VariableReferenceExpression b = p.variable("b");
@@ -209,7 +209,7 @@ public void testSingleSourceWithSetSemantics()
209209
@Test
210210
public void testTwoSourcesWithSetSemantics()
211211
{
212-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
212+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
213213
.on(p -> {
214214
VariableReferenceExpression a = p.variable("a");
215215
VariableReferenceExpression b = p.variable("b");
@@ -288,7 +288,7 @@ public void testTwoSourcesWithSetSemantics()
288288
@Test
289289
public void testThreeSourcesWithSetSemantics()
290290
{
291-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
291+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
292292
.on(p -> {
293293
VariableReferenceExpression a = p.variable("a");
294294
VariableReferenceExpression b = p.variable("b");
@@ -399,7 +399,7 @@ public void testThreeSourcesWithSetSemantics()
399399
@Test
400400
public void testTwoCoPartitionedSources()
401401
{
402-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
402+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
403403
.on(p -> {
404404
VariableReferenceExpression a = p.variable("a");
405405
VariableReferenceExpression b = p.variable("b");
@@ -482,7 +482,7 @@ public void testTwoCoPartitionedSources()
482482
public void testCoPartitionJoinTypes()
483483
{
484484
// both sources are prune when empty, so they are combined using inner join
485-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
485+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
486486
.on(p -> {
487487
VariableReferenceExpression a = p.variable("a");
488488
VariableReferenceExpression b = p.variable("b");
@@ -557,7 +557,7 @@ public void testCoPartitionJoinTypes()
557557
values("d"))))))));
558558

559559
// only the left source is prune when empty, so sources are combined using left join
560-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
560+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
561561
.on(p -> {
562562
VariableReferenceExpression a = p.variable("a");
563563
VariableReferenceExpression b = p.variable("b");
@@ -632,7 +632,7 @@ public void testCoPartitionJoinTypes()
632632
values("d"))))))));
633633

634634
// only the right source is prune when empty. the sources are reordered so that the prune when empty source is first. they are combined using left join
635-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
635+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
636636
.on(p -> {
637637
VariableReferenceExpression a = p.variable("a");
638638
VariableReferenceExpression b = p.variable("b");
@@ -707,7 +707,7 @@ public void testCoPartitionJoinTypes()
707707
values("c"))))))));
708708

709709
// neither source is prune when empty, so sources are combined using full join
710-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
710+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
711711
.on(p -> {
712712
VariableReferenceExpression a = p.variable("a");
713713
VariableReferenceExpression b = p.variable("b");
@@ -785,7 +785,7 @@ public void testCoPartitionJoinTypes()
785785
@Test
786786
public void testThreeCoPartitionedSources()
787787
{
788-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
788+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
789789
.on(p -> {
790790
VariableReferenceExpression a = p.variable("a");
791791
VariableReferenceExpression b = p.variable("b");
@@ -896,7 +896,7 @@ public void testThreeCoPartitionedSources()
896896
@Test
897897
public void testTwoCoPartitionLists()
898898
{
899-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
899+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
900900
.on(p -> {
901901
VariableReferenceExpression a = p.variable("a");
902902
VariableReferenceExpression b = p.variable("b");
@@ -1041,7 +1041,7 @@ public void testTwoCoPartitionLists()
10411041
@Test
10421042
public void testCoPartitionedAndNotCoPartitionedSources()
10431043
{
1044-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
1044+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
10451045
.on(p -> {
10461046
VariableReferenceExpression a = p.variable("a");
10471047
VariableReferenceExpression b = p.variable("b");
@@ -1149,7 +1149,7 @@ public void testCoPartitionedAndNotCoPartitionedSources()
11491149
@Test
11501150
public void testCoerceForCopartitioning()
11511151
{
1152-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
1152+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
11531153
.on(p -> {
11541154
VariableReferenceExpression a = p.variable("a");
11551155
VariableReferenceExpression b = p.variable("b");
@@ -1242,7 +1242,7 @@ public void testCoerceForCopartitioning()
12421242
@Test
12431243
public void testTwoCoPartitioningColumns()
12441244
{
1245-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
1245+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
12461246
.on(p -> {
12471247
VariableReferenceExpression a = p.variable("a");
12481248
VariableReferenceExpression b = p.variable("b");
@@ -1326,7 +1326,7 @@ public void testTwoCoPartitioningColumns()
13261326
@Test
13271327
public void testTwoSourcesWithRowAndSetSemantics()
13281328
{
1329-
tester().assertThat(new ImplementTableFunctionSource(tester().getMetadata()))
1329+
tester().assertThat(new TransformTableFunctionToTableFunctionProcessor(tester().getMetadata()))
13301330
.on(p -> {
13311331
VariableReferenceExpression a = p.variable("a");
13321332
VariableReferenceExpression b = p.variable("b");

0 commit comments

Comments
 (0)