-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Interface (from 2.0 Roadmap) #313
Comments
@dropofwill do you like to become maintainer? I have no time |
I feel a little awkward jumping in like this without even making a PR yet, but I do plan on moving forward with these 2.0 changes (as well as looking into performance), so if none of the current contributors is able to I'd be willing (it'd be nice to keep updates in a single code base). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From the Roadmap
Simplify the interface by only doing one thing, accepting an HTML string, a CSS string and inlining it.
a. The options currently in 1.8.0 are now documented so we can evaluate what should exist in 2.0
b. There are some vagaries around exactly how the CSS should be inlined, HTML Entities, UTF-8 encoding, base URLs, and such that lead to the contradictory mess that exists in 1.8
From my perspective nailing this down is the most important task towards doing any dev work done towards a 2.0 release.
Given the API
Premailer(html_string, css_string, options = {})
, what options are still necessary? Are we still planning to target justNokogiri
andNokogumbo
?These are the options as documented currently. Which are still necessary? This is my first draft, after a cursory read through the repo.
a href=""
link. Do not include the initial?
.script
elements. Default is true.contenteditable
attributes. Default is true.link rel=stylesheet
and style elements. Default is false.$stderr
. Default is false.link rel=stylesheet
tags. Default is true.style
tags. Default is true.:nokogiri
,:nokogumbo
or:hpricot
. Default is:nokogiri
.For b. can anyone elaborate on what the expected behavior is supposed to be?
The text was updated successfully, but these errors were encountered: