-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oga Adapter #283
Comments
You can replace Nokogiri with Nokogumbo one.Release with this option will be shortly. |
Or you can provide Oga adapter to be merged into Premailer. |
@akzhan Unfortunately the adapter interface is incredibly tied to Nokogiri (or libraries like Nokogumbo that follow its interface). We made it work in pakyow, but it's not something I'd want to see in Premailer as-is. Doing it correctly would be a larger effort of redesigning the adapter interface. Willing to help, but is redesigning things at this level something that you all are open to doing? |
Yes, any good contribution that did project better will be landed Вт, 28 июня 2016 г. в 0:59, Bryan Powell [email protected]:
|
Hello! We're trying to remove Nokogiri as a dependency in Pakyow (using Oga instead). The problem is that our mailer lib uses Premailer, which is currently setup to use the Nokogiri adapter. To use Oga throughout the project we'd like contribute an appropriate Premailer adapter.
Has this been attempted? If not, any tips before getting started?
The text was updated successfully, but these errors were encountered: