Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small PyPI generation improvements #1363

Open
3 tasks
wolfv opened this issue Jan 20, 2025 · 3 comments
Open
3 tasks

Small PyPI generation improvements #1363

wolfv opened this issue Jan 20, 2025 · 3 comments
Labels
good first issue Good for newcomers

Comments

@wolfv
Copy link
Member

wolfv commented Jan 20, 2025

I found two small issues when generating the recipe for zarr:

  • Upstream uses MIT License which is not valid SPDX. We should maybe make a HashMap or other lookup to associate the right SPDX license if possible.
  • Upstream uses a dependency with an extra for numcodecs which gets wrongly translated to numcodecs [crc32c]>=0.14

Also, the description is printed as a really long single line string but IDK if we can change this with serde_yaml.

  • When I generated a recipe for bagels, I noticed that we are not detecting noarch: python. If we detect that no compiler is needed, or that there are py-none wheels we should automatically insert the noarch: python option in the build section.
@wolfv wolfv added the good first issue Good for newcomers label Jan 21, 2025
@wolfv
Copy link
Member Author

wolfv commented Jan 22, 2025

When generating a recipe for quantity-array, the URL / filename should be normalized to quantity_array. Also, any non-alphanumeric character sequences should be reduced to - before normalizing I believe.

https://packaging.python.org/en/latest/specifications/binary-distribution-format/#escaping-and-unicode

https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization

        # Additionally, non-alphanumeric values in the distribution are
        # normalized to underscores (_), meaning hyphens can never occur
        # before `-{version}`.

@lucascolley
Copy link
Contributor

gh-1373 addressed the url formatting somewhat, but it seems like the edge cases mentioned in #1363 (comment) require a bit more work

@wolfv
Copy link
Member Author

wolfv commented Feb 8, 2025

It might be nice to figure out if we can / should add build_requirements to the host dependencies.

E.g. I tried to generate a recipe for truststore and it was missing flit-core as a host dep.

It will probably be tricky to figure out the right compilers needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants