Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RE2] Feature Request: Detach "Disable Camera Light" from FirstPerson and fix re2_sharpness_removal.lua #1192

Open
RGB00255 opened this issue Feb 19, 2025 · 2 comments

Comments

@RGB00255
Copy link

RGB00255 commented Feb 19, 2025

Is your feature request related to a problem? Please describe.
This game features a light source around the character that persists permanently and can be quite jarring once noticed. There is also a sharpness filter that cannot be adjusted or toggled natively in-game; the existing lua file (re2_sharpness_removal.lua) has this ability and should be fixed.

Describe the solution you'd like

  1. In the options for FirstPerson exists a toggle for the character camera light, this option works great and should be decoupled and placed somewhere else (likely in Camera). This would allow us to disable the camera light without needing to use FirstPerson. The provided screenshots show the camera light being disabled. This is how it would look if we were able to disable the light in third person (minus the head and freecam).

Currently, I do not have a workaround.

  1. RE2.zip includes lua scripts and among them is one "re2_sharpness_removal.lua". Inside of this file, there are a few things to note and a possible permanent solution to disable/adjust sharpening. The first line should be removed as (I believe) this script should no longer be considered depreciated. While the toggles for sharpness and TAA may not work, the parts that DO actually work are commented out, noted with "doesn't seem to change anything...".

I noted this in issue #1161 in this comment where uncommenting these lines will work as (un?)intended.

Screenshots showcasing camera light on/off and sharpness set to 0/1 are listed in additional context.

Describe alternatives you've considered
In this same issue there is a user that claimed they were able to disable sharpening using this ReShade Addon, though I was not able to get ReShade to work, presumably because of REFramework's ImGui (I have no idea I am just assuming).

I also tried using a search engine (Google, DuckDuckGo) and could not find an alternate solution. For the character lights, all I found was this request topic on NexusMods with no response.

Additional context
Camera light off:
Image

Camera light on:
Image


Sharpness 0:
Image

Sharpness 1:
Image

@RGB00255
Copy link
Author

RGB00255 commented Feb 19, 2025

I should note that in these examples I am using the DX12 build and the pd-upscaler fork.

@RGB00255 RGB00255 changed the title [RE2] Detach "Disable Camera Light" from FirstPerson and fix re2_sharpness_removal.lua [RE2] Feature Request: Detach "Disable Camera Light" from FirstPerson and fix re2_sharpness_removal.lua Feb 20, 2025
@RGB00255
Copy link
Author

Sharpness returns during cutscenes, rendering the slider useless in these situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant