Skip to content

Commit bdbca96

Browse files
committed
Handle both stored and deflate entries.
Remove link title which needed to access assembly bytes to render. Add sqlite db to gitignore.
1 parent 294f856 commit bdbca96

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ autom4te.cache/
2828
*.tar.gz
2929
tarballs/
3030
test-results/
31-
Thumbs.db
31+
Thumbs.db
32+
*.sqlite3
3233

3334
# Mac bundle stuff
3435
*.dmg

Data/PackageData.cs

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,20 @@ public async Task<Stream> OpenAsync () {
6666
req.Headers.Add ("Range", "bytes=" + deflateStart + "-" + (deflateStart + CompressedSize - 1));
6767

6868
resp = await client.SendAsync (req);
69-
var stream = await resp.Content.ReadAsStreamAsync();
69+
Stream stream = await resp.Content.ReadAsStreamAsync ();
70+
if (Mode == 8) // deflate
71+
{
72+
stream = new DeflateStream (stream, CompressionMode.Decompress, false);
73+
}
74+
else {
75+
if (Mode != 0) { // store
76+
throw new NotSupportedException ("Compression mode " + Mode + " not supported");
77+
}
78+
}
7079

71-
var ds = new DeflateStream (stream, CompressionMode.Decompress, false);
72-
ds.CopyTo (ms);
80+
stream.CopyTo (ms);
7381
ms.Position = 0;
82+
stream.Dispose ();
7483
return ms;
7584
}
7685
}

Pages/packages/details.cshtml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,10 @@ else
401401
var cls = (active ? "active " : "") + "public-api";
402402
<li>
403403
<a class="@cls"
404-
href="/packages/@Uri.EscapeDataString(package.Id)/@Uri.EscapeDataString(package.Version.ShortVersionString)/lib/@Uri.EscapeDataString(framework.Moniker)/@Uri.EscapeDataString(a.FileName)"
405-
title="@a.Definition.Name.Version.ToString()">
404+
href="/packages/@Uri.EscapeDataString(package.Id)/@Uri.EscapeDataString(package.Version.ShortVersionString)/lib/@Uri.EscapeDataString(framework.Moniker)/@Uri.EscapeDataString(a.FileName)"
405+
@*Rendering this title is problematic because it attempts to load the assembly*@
406+
@*title="@a.Definition.Name.Version.ToString()"*@
407+
>
406408
<span class="glyphicon glyphicon-@GetIcon(a)" aria-hidden="true"></span>&nbsp;@a.FileName
407409
</a>
408410
</li>

0 commit comments

Comments
 (0)