Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: g:lsp_async_completion not effective, lsp#omni#complete is always async #1520

Open
notuxic opened this issue Dec 19, 2023 · 0 comments

Comments

@notuxic
Copy link

notuxic commented Dec 19, 2023

PR #28 introduced the option g:lsp_async_completion, which allows to run lsp#omni#complete in sync-mode, ie. have the function wait for the results and return them, instead of returning v:none and adding the results later.

This allowed the omnifunc-implementation to be used in chaining completion-managers such as mucomplete, which rely on the (existence of) results to decide if the next completion should be called.

PR #391 changed this, returning v:none in either case, and thus breaking plugins which rely on the omnifunc actually returning any results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant