Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game frozen after choosing game folder at first launch #31218

Open
Redplcs opened this issue Dec 21, 2024 · 5 comments
Open

Game frozen after choosing game folder at first launch #31218

Redplcs opened this issue Dec 21, 2024 · 5 comments
Labels
area:settings priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@Redplcs
Copy link

Redplcs commented Dec 21, 2024

Type

Game behaviour

Bug description

So I downloaded lazer through old client. It installed and launched. After installation it asked me to configure my game. When I choose folder for the lazer game, it returned me into a main menu. I was not expecting that and i went back to configure the game though in-game settings. I pressed choose game folder again, selected folder and it froze. The music continued playing, but everything else not

Alt+F4 does not worked, so i killed the process

Screenshots or videos

image

Version

2024.1219.2-lazer

Logs

compressed-logs.zip

@bdach
Copy link
Collaborator

bdach commented Dec 23, 2024

2024-12-21 12:31:31 [verbose]: Migrating osu! data from "D:\osu-lazer" to "D:\osu-lazer"...

I'm not sure how you've managed to do this but this sort of migration should not be permissible. Needs investigating.

@bdach bdach added area:settings priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Dec 23, 2024
@Redplcs
Copy link
Author

Redplcs commented Dec 23, 2024

2024-12-21 12:31:35 [verbose]: Realm usage isolated via compact

I think it's realm's blame, not migration's. The threadlock acquired somewhere on sending callback into synchronization context

@Redplcs
Copy link
Author

Redplcs commented Dec 23, 2024

Sooo... Now I think it's realm's issue 100%. I somehow deadlocked whole game by... starting another migration? while previous migration working on background. By starting new migration, the realm blocked all operations while there was importing tasks.

runtime logs

2024-12-21 12:31:31 [verbose]: Migrating osu! data from "D:\osu-lazer" to "D:\osu-lazer"...

database logs

2024-12-21 12:31:31 [verbose]: Attempting to block all realm operations for migration.
2024-12-21 12:31:31 [verbose]: Lock acquired for blocking operations
2024-12-21 12:31:35 [verbose]: [3d734] Import successfully completed!
2024-12-21 12:31:35 [verbose]: Realm usage isolated via compact

I think deadlock happened in that 4ms frame. Assume that lock requested while there was running task on importing skin. When the skin imported, realm started to blocking all operation, but all other tasks wasn't done. Other task requested to lock realm, causing dead lock... on both side??

I'm not really sure, because I never looked osu code. It's just my opinion, nothing else

@peppy
Copy link
Member

peppy commented Dec 24, 2024

Does the issue only happen when you migrate from and to the same folder? Have you tried doing a migration that makes sense?

@Redplcs
Copy link
Author

Redplcs commented Dec 24, 2024

Does the issue only happen when you migrate from and to the same folder? Have you tried doing a migration that makes sense?

I didn't tried to migrate to other folder. After the restart, the game showed configuring menu where I choose same folder. Everything happened as expected without dead locks.

I'll try to repeat the process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Development

No branches or pull requests

3 participants