forked from canonical/snapd
-
Notifications
You must be signed in to change notification settings - Fork 0
/
run-checks
executable file
·284 lines (243 loc) · 7.71 KB
/
run-checks
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
#!/bin/sh -eu
if [ -n "${TRAVIS_BUILD_NUMBER:-}" ]; then
echo travis_fold:start:env
printenv | sort
echo travis_fold:end:env
fi
export LANG=C.UTF-8
export LANGUAGE=en
if command -v goctest >/dev/null; then
goctest="goctest"
else
goctest="go test"
fi
COVERMODE=${COVERMODE:-atomic}
# ensure we use go-1.10 by default
export PATH=/usr/lib/go-1.10/bin:${PATH}
# add workaround for https://github.com/golang/go/issues/24449
if [ "$(uname -m)" = "s390x" ]; then
if go version | grep -q go1.10; then
echo "covermode 'atomic' crashes on s390x with go1.10, reseting "
echo "to 'set'. see https://github.com/golang/go/issues/24449"
COVERMODE="set"
fi
fi
export GOPATH="${GOPATH:-$(realpath "$(dirname "$0")"/../../../../)}"
export PATH="$PATH:${GOPATH%%:*}/bin"
short=
STATIC=
UNIT=
SPREAD=
case "${1:-all}" in
all)
STATIC=1
UNIT=1
;;
--static)
STATIC=1
;;
--unit)
UNIT=1
;;
--short-unit)
UNIT=1
short=1
;;
--spread)
SPREAD=1
;;
*)
echo "Wrong flag ${1}. To run a single suite use --static, --unit, --spread."
exit 1
esac
CURRENTTRAP="true"
EXIT_CODE=99
store_exit_code() {
EXIT_CODE=$?
}
exit_with_exit_code() {
exit $EXIT_CODE
}
addtrap() {
CURRENTTRAP="$CURRENTTRAP ; $1"
# shellcheck disable=SC2064
trap "store_exit_code; $CURRENTTRAP ; exit_with_exit_code" EXIT
}
endmsg() {
if [ $EXIT_CODE -eq 0 ]; then
p="success.txt"
m="All good, what could possibly go wrong."
else
p="failure.txt"
m="Crushing failure and despair."
fi
echo
if [ -t 1 ] && [ -z "$STATIC" ]; then
cat "data/$p"
else
echo "$m"
fi
}
addtrap endmsg
# Append the coverage profile of a package to the project coverage.
append_coverage() (
profile="$1"
if [ -f "$profile" ]; then
grep -v "^mode:" -- "$profile" >> .coverage/coverage.out || true
rm "$profile"
fi
)
missing_interface_spread_test() {
snap_yaml="tests/lib/snaps/test-snapd-policy-app-consumer/meta/snap.yaml"
core_snap_yaml="tests/lib/snaps/test-snapd-policy-app-provider-core/meta/snap.yaml"
classic_snap_yaml="tests/lib/snaps/test-snapd-policy-app-provider-classic/meta/snap.yaml"
for iface in $(go run ./tests/lib/list-interfaces.go) ; do
search="plugs: \\[ $iface \\]"
case "$iface" in
bool-file|gpio|hidraw|i2c|iio|serial-port|spi)
# skip gadget provided interfaces for now
continue
;;
dbus|content)
search="interface: $iface"
;;
autopilot)
search='plugs: \[ autopilot-introspection \]'
;;
esac
if ! grep -q "$search" "$snap_yaml" ; then
echo "Missing high-level test for interface '$iface'. Please add to:"
echo "* $snap_yaml"
echo "* $core_snap_yaml (if needed)"
echo "* $classic_snap_yaml (if needed)"
exit 1
fi
done
}
if [ "$STATIC" = 1 ]; then
./get-deps.sh
# Run static tests.
echo Checking docs
./mdlint.py ./*.md docs/*.md
echo Checking formatting
fmt=""
for dir in $(go list -f '{{.Dir}}' ./... | grep -v '/vendor/' ); do
s="$(gofmt -s -l "$dir" | grep -v /vendor/ || true)"
if [ -n "$s" ]; then
fmt="$s\\n$fmt"
fi
done
if [ -n "$fmt" ]; then
echo "Formatting wrong in following files:"
echo "$fmt" | sed -e 's/\\n/\n/g'
exit 1
fi
# go vet
echo Running vet
go list ./... | grep -v '/vendor/' | xargs go vet
echo 'Check for usages of http.Status*'
got=""
for dir in $(go list -f '{{.Dir}}' ./... | grep -v '/vendor/' ); do
s="$(grep -nP 'http\.Status(?!Text)' "$dir"/*.go || true)"
if [ -n "$s" ]; then
got="$s\\n$got"
fi
done
if [ -n "$got" ]; then
echo 'Usages of http.Status*, we prefer the numeric values directly:'
echo "$got"
exit 1
fi
if command -v shellcheck >/dev/null; then
echo Checking shell scripts...
( git ls-files -z 2>/dev/null ||
find . \( -name .git -o -name vendor \) -prune -o -print0 ) |
xargs -0 file -N |
awk -F": " '$2~/shell.script/{print $1}' |
xargs shellcheck
regexp='GOPATH(?!%%:\*)(?!:)[^= ]*/'
if grep -qPr --exclude HACKING.md --exclude 'Makefile.*' --exclude-dir .git --exclude-dir vendor "$regexp"; then
echo "Using GOPATH as if it were a single entry and not a list:"
grep -PHrn -C1 --color=auto --exclude HACKING.md --exclude 'Makefile.*' --exclude-dir .git --exclude-dir vendor "$regexp"
echo "Use GOHOME, or {GOPATH%%:*}, instead."
exit 1
fi
unset regexp
fi
echo Checking spelling errors
if ! command -v misspell >/dev/null; then
go get -u github.com/client9/misspell/cmd/misspell
fi
for file in *; do
if [ "$file" = "vendor" ] || [ "$file" = "po" ]; then
continue
fi
misspell -error -i auther,PROCES,PROCESSS,proces,processs,exportfs "$file"
done
echo Checking for ineffective assignments
if ! command -v ineffassign >/dev/null; then
go get -u github.com/gordonklaus/ineffassign
fi
# ineffassign knows about ignoring vendor/ \o/
ineffassign .
echo Checking for naked returns
if ! command -v nakedret >/dev/null; then
go get -u github.com/alexkohler/nakedret
fi
got=$(go list ./... | grep -v '/osutil/udev/' | grep -v '/vendor/' | xargs nakedret 2>&1)
if [ -n "$got" ]; then
echo "$got"
exit 1
fi
echo Checking all interfaces have minimal spread test
missing_interface_spread_test
# FIXME: re-add staticcheck with a matching version for the used go-version
fi
if [ "$UNIT" = 1 ]; then
./get-deps.sh
echo Building
go build -v github.com/snapcore/snapd/...
# tests
echo Running tests from "$PWD"
if [ "$short" = 1 ]; then
# shellcheck disable=SC2046
$goctest -short -v $(go list ./... | grep -v '/vendor/' )
else
# Prepare the coverage output profile.
rm -rf .coverage
mkdir .coverage
echo "mode: $COVERMODE" > .coverage/coverage.out
if dpkg --compare-versions "$(go version | awk '$3 ~ /^go[0-9]/ {print substr($3, 3)}')" ge 1.10; then
# shellcheck disable=SC2046
$goctest -v -coverprofile=.coverage/coverage.out -covermode="$COVERMODE" $(go list ./... | grep -v '/vendor/' )
else
for pkg in $(go list ./... | grep -v '/vendor/' ); do
go test -i "$pkg"
$goctest -v -coverprofile=.coverage/profile.out -covermode="$COVERMODE" "$pkg"
append_coverage .coverage/profile.out
done
fi
# upload to codecov.io if on travis
if [ "${TRAVIS_BUILD_NUMBER:-}" ]; then
curl -s https://codecov.io/bash | bash /dev/stdin -f .coverage/coverage.out
fi
fi
fi
if [ "$SPREAD" = 1 ]; then
TMP_SPREAD="$(mktemp -d)"
addtrap "rm -rf \"$TMP_SPREAD\""
export PATH=$TMP_SPREAD:$PATH
( cd "$TMP_SPREAD" && curl -s -O https://niemeyer.s3.amazonaws.com/spread-amd64.tar.gz && tar xzvf spread-amd64.tar.gz )
spread google: google-upgrade:tests/upgrade/
# cleanup the debian-ubuntu-14.04
rm -rf debian-ubuntu-14.04
fi
UNCLEAN="$(git status -s|grep '^??')" || true
SKIP_UNCLEAN=${SKIP_UNCLEAN=}
if [ -n "$UNCLEAN" ] && [ -z "$SKIP_UNCLEAN" ]; then
cat <<EOF
There are files left in the git tree after the tests:
$UNCLEAN
EOF
exit 1
fi