Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cfs-profiles configuration clearer #98

Open
kriansa opened this issue May 5, 2023 · 1 comment · May be fixed by #115
Open

Make cfs-profiles configuration clearer #98

kriansa opened this issue May 5, 2023 · 1 comment · May be fixed by #115

Comments

@kriansa
Copy link

kriansa commented May 5, 2023

Currently, the CFS tuning happens when the option is enabled and what it does is switching between the two profiles when the power source is either battery or ac. However, there's no place in the config file where that information is stated:

// Latency profiles the kernel's Completely Fair Scheduler
cfs-profiles enable=true {
    // The kernel-default values which are ideal for battery life and servers
    default latency=6 nr-latency=8 wakeup-granularity=1.0 bandwidth-size=5 preempt="voluntary"

    // Zen CFS parameters that make the desktop more responsive
    responsive latency=4 nr-latency=10 wakeup-granularity=0.5 bandwidth-size=3 preempt="full"
}

Ideally, I'd swap the profile names default and responsive to battery and ac respectively, so they reflect better what the scheduler is actually doing. An alternative would be to simply add a comment making that clearer.

Would you be willing to accept patches for either?

@liammcdermott
Copy link

Agreed, I'm very confused by this section of the config. I'm also wondering if it's possible to switch the profiles, and how I might see which profile is currently in use.

If my machine is on AC and that makes it choose responsive, I'd love to know that's the case. A comment and README update would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants