[BUG] VPN: ignores "Ask for password every time" setting, saving password on connect.

[nathancurry]

Environment:

$ rpm -q cosmic-settings gnome-control-center kernel | head -3
cosmic-settings-1.0.0~alpha.6-1.fc41.x86_64
gnome-control-center-47.3-1.fc41.x86_64
kernel-6.12.15-200.fc41.x86_64

Replication steps:

1. Configure VPN, selecting "Ask for this password every time" for the Password field
2. Connect to VPN
3. Disconnect from VPN
4. Connect again, password will be saved

Workaround:

Run after connecting:

nmcli con mod <vpn-name> +vpn.data password-flags=2

Details:

Running Fedora 41, I recently switched from default Gnome desktop to Cosmic from the Fedora repos.

I previously imported my VPN settings while on the default Gnome DE. It requires a PIN + token, so I can't save the password.

Every time I connect, Cosmic saves the password, so I either have to reset via the GUI or run nmcli con mod <vpn-name> +vpn.data password-flags=2

Note that this appears to occur specifically on connect. If after connecting, I reset with nmcli, the setting stays as expected until next time I reconnect.

Additional comments:

Rust is a little hard for me to read, but this looks like it may be the result of a temporary hard-coded fix in the VPN connect function to get the password to reliably save.

Anyway, thank you guys for Cosmic, it's a joy to use.