signAndSend does not respect modified signedTransaction field

[valentunn]

Hey, thats Valentin from Nova Wallet

We are currently testing integration of wrapped proxy signing based on recently implemented allowCallDataAlteration.
The allowCallDataAlteration itself works as expected and the payload validation logic is getting skipped. However, we noticed that an attempt to send proxy-wrapped tx is failing with "Invalid signature" response from the node.

After some debugging and investigaiton we found out that despite signedTransaction is handled in signViaSigner in polkadot-js api library, polkadot-js apps itself doesnt use signAndSend which pipes signedTransaction into observeSubscribe but actually uses signAsync and send separetely, which causes signedTransaction to be lost in between since signViaSigner mutates only signature and not the modified tx itself, so send uses combination of original extrinsic and signature for the modified transaction

[ap211unitech]

@valentunn If I understood correctly, submitting extrinsics via a proxy account fails in the Apps UI because signAsync does not preserve the modified transaction, causing a signature mismatch. Is that correct? because I did couple of transactions with proxies, all worked fine.

[valentunn]

Hey @ap211unitech . I am talking about a situation when the signer is modifying the call data by wrapping supplied call into proxy.proxy and returning the result in signedTransaction field. The issue is that sendAsync uses original transaction with the signature returned from the signer which causes submission error because of signature mismatch, since the modified transaction should be used instead. from I can help you with providing a debuggable build of Nova Wallet where you can test this in our Dapp Browser and debug the behavior of the polkadot-js/apps by connecting the chrome dev tools to the WebView