Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set identity on accounts #10581

Merged
merged 4 commits into from
May 17, 2024
Merged

Fix set identity on accounts #10581

merged 4 commits into from
May 17, 2024

Conversation

TarikGul
Copy link
Member

closes: #10580

@joepetrowski
Copy link
Contributor

Looks like this fixes setting Identity, but there also needs to be a PR to change Identity rendering? As in, when I'm on the Relay Chain, accounts with Identity on the People Chain should still render with that Identity.

@TarikGul
Copy link
Member Author

Looks like this fixes setting Identity, but there also needs to be a PR to change Identity rendering? As in, when I'm on the Relay Chain, accounts with Identity on the People Chain should still render with that Identity.

Yea this only fixes setting the identity. The actual retrieving of the information is going to be a way larger overhaul. I don't know exactly how I am going to do it yet, but I will have a plan figured out today. Same as the above, but basically we need to keep the old while bringing in the new, so that we don't break everything for every chain that wont be using this identity structure.

@joepetrowski
Copy link
Contributor

The actual retrieving of the information is going to be a way larger overhaul. I don't know exactly how I am going to do it yet

Hmm, I would not expect that, as the Identity on system chains rendered from the Relay Chain. I would expect that it just means always making a wss connection with People Chain and changing the provider of Identity info?

@TarikGul
Copy link
Member Author

Tested on both Polkadot, and westend-people and the logic works as it should.

@TarikGul TarikGul added the -auto label May 17, 2024
@polkadot-js-bot polkadot-js-bot merged commit f0ebd41 into master May 17, 2024
7 checks passed
@polkadot-js-bot polkadot-js-bot deleted the tg-fix-identity-bug branch May 17, 2024 01:45
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Identity fails on accounts that already have identities set
3 participants