Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only LSB BitVec is currently supported, found bitvec::order::Msb0 #5588

Open
1 of 4 tasks
aurexav opened this issue Apr 10, 2023 · 2 comments
Open
1 of 4 tasks

Only LSB BitVec is currently supported, found bitvec::order::Msb0 #5588

aurexav opened this issue Apr 10, 2023 · 2 comments
Labels
P3 - Low Non-essential improvements or minor fixes. Can be scheduled flexibly as time permits.
Milestone

Comments

@aurexav
Copy link

aurexav commented Apr 10, 2023

  • I'm submitting a ...
  • Bug report
  • Feature request
  • Support request
  • Other
  • What is the current behavior and expected behavior?

We cannot connect our chain anymore.

Due to #5585.

AFAIK, this change will affect any chain which uses parity-bridges-common.

  • Please tell us about your environment:

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fdarwiniacrab-rpc.dwellir.com#/explorer

@jacogr
Copy link
Member

jacogr commented Apr 10, 2023

Umpf. Will revert that specific throw and turn it into a warning as a start.

@jacogr jacogr mentioned this issue Apr 10, 2023
@jacogr jacogr added this to the todo milestone Apr 10, 2023
@jacogr
Copy link
Member

jacogr commented Apr 12, 2023

We are back to where we were, aka not-failing. However keeping this open so we can properly address this TODO so the toHuman & toBoolArray formatting can work as expected -

if (!isLsb) {
// TODO To remove this limitation, we need to pass an extra info flag
// through to the TypeDef (Here we could potentially re-use something
// like index (???) to indicate and ensure we use it to pass to the
// BitVec constructor - which does handle this type)
//
// See https://github.com/polkadot-js/api/issues/5588
// throw new Error(`Only LSB BitVec is currently supported, found ${bitOrder.namespace}`);
}
return {
info: TypeDefInfo.Plain,
type: 'BitVec'
};

@TarikGul TarikGul added the P3 - Low Non-essential improvements or minor fixes. Can be scheduled flexibly as time permits. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 - Low Non-essential improvements or minor fixes. Can be scheduled flexibly as time permits.
Projects
None yet
Development

No branches or pull requests

3 participants