Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLChannel stops logging on LoggingSubsystem shutdown #4529

Open
2 tasks
aleks-f opened this issue Apr 13, 2024 · 1 comment
Open
2 tasks

SQLChannel stops logging on LoggingSubsystem shutdown #4529

aleks-f opened this issue Apr 13, 2024 · 1 comment
Assignees
@aleks-f
Labels
bug
Milestone
Release 1.14.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Apr 13, 2024

Describe the bug

  • last log messages not logged on shutdown
  • code after main while loop in run is never reached (thread abruptly terminated?)
@aleks-f aleks-f added the bug label Apr 13, 2024
@aleks-f aleks-f added this to the Release 1.14.0 milestone Apr 13, 2024
@aleks-f aleks-f self-assigned this Apr 13, 2024
aleks-f added a commit that referenced this issue Apr 13, 2024
@aleks-f
enh(SQLLogger): #4529 (wip)
016faef
@matejk
Copy link
Contributor

matejk commented Apr 14, 2024

I get this static analysis warning in SQLChannel dtor:

/poco/Data/src/SQLChannel.cpp:112:3: Call to virtual method 'SQLChannel::close' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]

matejk added a commit that referenced this issue Apr 14, 2024
@matejk
enh(SQLiteTest): extend unit test to destroy SQL channel while it has…
7fe24c0 
… pending messages. (#4529)
matejk added a commit that referenced this issue Apr 14, 2024
@matejk
enh(SQLiteTest): extend unit test to destroy SQL channel while it has…
54b6e21 
… pending messages. (#4529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleks-f aleks-f

Labels
bug
Projects
1.14
Status: No status
Milestone
Release 1.14.0
Development

No branches or pull requests
2 participants
@matejk @aleks-f