Merge pull request #76 from pocketpy/add-compiler-options

Add flag to suppress warnings

Author: faze-geek

CMakeLists.txt

@@ -8,13 +8,25 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 include_directories(numpy/include)
 include_directories(pocketpy/include)
 
+option(SHOW_XTENSOR_WARNINGS "Show warnings from xtensor" OFF)
+
 add_subdirectory(pocketpy)
 
 if(MSVC)
     add_compile_options(/wd4018 /wd4172 /wd4819)
     add_compile_options(/bigobj)
 endif()
 
+# Suppress xtensor warnings if SHOW_XTENSOR_WARNINGS is OFF
+if(NOT SHOW_XTENSOR_WARNINGS)
+    add_compile_definitions(SUPPRESS_XTENSOR_WARNINGS)
+    if(MSVC)
+        add_compile_options(/wd4244 /wd4267 /wd4018)
+    else()
+        add_compile_options(-Wno-sign-compare -Wno-conversion -Wno-unused-variable -Wno-unused-parameter)
+    endif()
+endif()
+
 add_executable(${PROJECT_NAME} test_main.cpp numpy/src/numpy.cpp)
 
 set_property(TARGET ${PROJECT_NAME} PROPERTY VS_DEBUGGER_WORKING_DIRECTORY CMAKE_CURRENT_LIST_DIR)

numpy/include/numpy.hpp

@@ -12,13 +12,33 @@
 #include <utility>
 #include <vector>
 
+// Suppress xtensor warnings if SUPPRESS_XTENSOR_WARNINGS is set
+#ifdef SUPPRESS_XTENSOR_WARNINGS
+    #ifdef _MSC_VER
+        #pragma warning(push, 0)
+    #else
+        #pragma GCC diagnostic push
+        #pragma GCC diagnostic ignored "-Wall"
+        #pragma GCC diagnostic ignored "-Wextra"
+        #pragma GCC system_header
+    #endif
+#endif
+
 #include <xtensor/xarray.hpp>
 #include <xtensor/xio.hpp>
 #include <xtensor/xmath.hpp>
 #include <xtensor/xrandom.hpp>
 #include <xtensor/xsort.hpp>
 #include <xtensor/xview.hpp>
 
+#ifdef SUPPRESS_XTENSOR_WARNINGS
+    #ifdef _MSC_VER
+        #pragma warning(pop)
+    #else
+        #pragma GCC diagnostic pop
+    #endif
+#endif
+
 namespace pkpy {
 
 // Type aliases