Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Feature]: Correct the VS Code extension name in assets images #225

Open
Adam-it opened this issue Apr 17, 2024 · 3 comments
Open

💡 [Feature]: Correct the VS Code extension name in assets images #225

Adam-it opened this issue Apr 17, 2024 · 3 comments
Assignees
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Milestone

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Apr 17, 2024

🎯 Aim of the feature

Go over the assets images and sort out the naming so that it will be SharePoint Framework Toolkit in every image

📷 Images (if possible) with expected result

example image taken from the readme with this problem

image

🤔 Additional remarks or comments

No response

@Adam-it Adam-it added ⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors labels Apr 17, 2024
@Adam-it Adam-it added this to the v3.X milestone Apr 17, 2024
@tmaestrini
Copy link

I'm interested in being assigned… That's a good starting point! :)

@Adam-it
Copy link
Contributor Author

Adam-it commented Apr 18, 2024

Awesome! All yours

@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Apr 18, 2024
@Adam-it
Copy link
Contributor Author

Adam-it commented Apr 18, 2024

@tmaestrini so to maybe give you some more context or info that might be helpful to resolve this issue:

  • all of the images may be found in assets/images location
  • if you will need to recreate the images from scratch please do be aware that:
    • the primary color of SPFx Toolkit is #2A777C which should be used in text areas and arrows
    • we should use default Light + VS Code theme when creating images

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Projects
None yet
Development

No branches or pull requests

2 participants