Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the default tab name from the App project name to be less than 16 characters or provide an error message #263

Open
RickVanRousselt opened this issue Nov 6, 2021 · 0 comments
Assignees
Labels
good first issue Hacktoberfest https://hacktoberfest.digitalocean.com/ request: feature

Comments

@RickVanRousselt
Copy link
Collaborator

RickVanRousselt commented Nov 6, 2021

馃挕 Idea

When creating a new project you are not limited in the length the project name has. When you then want to create a tab, this is limited to 16 characters.

If you do not specify a name and just press enter the generator suggests the name of the project + " tab". It should perform a check if the name is longer than 16 characters and already cut that off at that limit. Or at least give you an error message if you enter too many characters. Now nothing happens.

newTabName

Is your feature related to a bug

no

Alternatives

In the tabgenerator the default name is set with

this.options.title + ' Tab',

the default should max be the first 11 characters of the title.

The validation method should also return a meaningful message if there are more than 16 characters.

Additional Info

The yeoman generator uses Inquirer.js for the promts. These can have validation scenarios.

@RickVanRousselt RickVanRousselt changed the title Feature request: Adjust the default tab name from the App project name to be less than 16 characters or provide an error message Adjust the default tab name from the App project name to be less than 16 characters or provide an error message Nov 6, 2021
@RickVanRousselt RickVanRousselt self-assigned this Feb 21, 2022
@appieschot appieschot added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Hacktoberfest https://hacktoberfest.digitalocean.com/ request: feature
Projects
None yet
Development

No branches or pull requests

2 participants