Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from 8.15.19 to 8.16.1 causes 'demand' frameloop issues with @react-spring/three #3228

Open
GibsDev opened this issue Apr 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@GibsDev
Copy link

GibsDev commented Apr 3, 2024

This seems to be related to the problem in this react-spring issue, but I've narrowed the conditions down to changing the version of @react-three/fiber.

For some reason when updating to 8.16.1, the react spring animations are stopping short of completion.

I am using a spring with an onUpdate function tha calls invalidate() so the screen will dynamically update when the animation spring changes.

Something about the upgrade from 8.15.19 to 8.16.1 has changed the invalidation behavior, and the animation stops short of completion.

I've outlined some details in the other issue here.

@CodyJasonBennett CodyJasonBennett added the bug Something isn't working label Apr 28, 2024
@CodyJasonBennett
Copy link
Member

This is probably caused by exactly https://github.com/pmndrs/react-three-fiber/releases/tag/v8.16.1. Maybe try 8.16.0.

@GibsDev
Copy link
Author

GibsDev commented May 12, 2024

This does not work with 8.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants