Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling Event propagation on instances is broken #3084

Open
ricardomatias opened this issue Nov 3, 2023 · 1 comment
Open

Cancelling Event propagation on instances is broken #3084

ricardomatias opened this issue Nov 3, 2023 · 1 comment

Comments

@ricardomatias
Copy link

Stopping the propagation of a click event on a instanced mesh, results in the parent node still having that same event triggered.

Example here

@ashleymvanduzer
Copy link

ashleymvanduzer commented Nov 10, 2023

I might be very wrong but I think it has to do with this line, seems like the canvas is exempt from the propagation rule, I guess out of necessity:
https://github.com/pmndrs/react-three-fiber/blob/2ad846f29b7172ab284561ad3afdd2bb739ef46d/packages/fiber/src/web/Canvas.tsx#L103C1-L105C12

Try wrapping the instances in a group and adding an event listener to the group and logging something, you'll see nothing from the group driven event print to the console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants