-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong "device" name #101
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, thanks for this awesome tool for three.js but I found a little bug in my mobile phone.
I'm using "Samsung Galaxy S21 Ultra" but the live demo page in the README.md says the device it is "huawei mate 40 pro 5g". It's really wrong but probably it's guessed it from the GPU model because both that Huawei's SoC and S21U's SoC has same "ARM Mali-G78" gpu.
I think rather then guessing the phone it'll be more accurate to just leave the GPU model with device specific display info. Or this guessing algorithm needed to change with better one with some values to stand on more then just GPU model and display info. Because nearly all SoC other then Qualcomm ones uses Mali GPUs in Android devices and this can cause really trouble to developers who didn't get this bug while developing.
The text was updated successfully, but these errors were encountered: