Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow query params #99

Open
michaelroth-xx opened this issue Oct 28, 2022 · 2 comments
Open

Allow query params #99

michaelroth-xx opened this issue Oct 28, 2022 · 2 comments
Labels
Question More information was requested

Comments

@michaelroth-xx
Copy link

Right now it is not possible to create a sitemap entry with query params. The input field simply permits typing in a questionmark. e.g.:

  • some-overview?page=2
  • /?location=[id]

Is there any reason for this? Or any workaround?

Thank you!

@boazpoolman boazpoolman added the Needs investigation Further information is requested label Nov 30, 2022
@ThomasValois
Copy link

Also very much interested in this feature, I have a couple of sites that would greatly benefit from this and are a little limited at the moment

@boazpoolman
Copy link
Member

Thanks @michaelroth-xx and @ThomasValois for your interest in this feature.

I've been thinking about it and it seems like an easy fix; just allow them in the pattern.

The only real issue I see here is the use of [] in the params.
In the pattern those characters are used to escape the fields, like; /page/[id].
Though in query params those might be used to specify the index in an array, like: /page?param[0]=test

I could say; all [] in the pattern that come after the ? should not be escaped as fields.
Though you then loose the ability to pass a dynamic value in the query params, like: /page?param=[id]

If any of you wanna help figure this out I'll be happy to implement it.

@boazpoolman boazpoolman added Question More information was requested and removed Needs investigation Further information is requested labels Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question More information was requested
Projects
None yet
Development

No branches or pull requests

3 participants