Skip to content

Commit 72637e0

Browse files
author
Xing Han Lu
authored
Merge pull request #587 from plotly/fix-link-baseball
Fix URL paths for baseball app (#patch) Former-commit-id: 6dde681
2 parents 8f05696 + 545b324 commit 72637e0

File tree

2 files changed

+18
-8
lines changed

2 files changed

+18
-8
lines changed

apps/dash-baseball-statistics/index.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
# import dash-core, dash-html, dash io, bootstrap
2+
import os
3+
24
import dash_core_components as dcc
35
import dash_html_components as html
46
from dash.dependencies import Input, Output
@@ -25,6 +27,8 @@
2527
from app import srv as server
2628

2729

30+
app_name = os.getenv("DASH_APP_PATH", "/dash-baseball-statistics")
31+
2832
# Layout variables, navbar, header, content, and container
2933
nav = Navbar()
3034

@@ -49,7 +53,7 @@
4953
# Declair function that connects other pages with content to container
5054
@app.callback(Output("page-content", "children"), [Input("url", "pathname")])
5155
def display_page(pathname):
52-
if pathname == "/":
56+
if pathname == app_name:
5357
return html.Div(
5458
[
5559
dcc.Markdown(
@@ -78,11 +82,11 @@ def display_page(pathname):
7882
],
7983
className="home",
8084
)
81-
elif pathname == "/team":
85+
elif pathname.endswith("/team"):
8286
return appMenu, menuSlider, teamLayout
83-
elif pathname == "/player":
87+
elif pathname.endswith("/player"):
8488
return appMenu, menuSlider, playerMenu, battingLayout
85-
elif pathname == "/field":
89+
elif pathname.endswith("/field"):
8690
return appMenu, menuSlider, playerMenu, fieldingLayout
8791
else:
8892
return "ERROR 404: Page not found!"

apps/dash-baseball-statistics/navbar.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,23 @@
11
# Import Bootstrap from Dash
2+
import os
3+
24
import dash_bootstrap_components as dbc
35

46

7+
app_name = os.getenv("DASH_APP_PATH", "/dash-baseball-statistics")
8+
59
# Navigation Bar fucntion
610
def Navbar():
711
navbar = dbc.NavbarSimple(
812
children=[
9-
dbc.NavItem(dbc.NavLink("Team Analysis", href="/team")),
10-
dbc.NavItem(dbc.NavLink("Batting Analysis", href="/player")),
11-
dbc.NavItem(dbc.NavLink("Pitching/Fielding Analysis", href="/field")),
13+
dbc.NavItem(dbc.NavLink("Team Analysis", href=f"{app_name}/team")),
14+
dbc.NavItem(dbc.NavLink("Batting Analysis", href=f"{app_name}/player")),
15+
dbc.NavItem(
16+
dbc.NavLink("Pitching/Fielding Analysis", href=f"{app_name}/field")
17+
),
1218
],
1319
brand="Home",
14-
brand_href="/",
20+
brand_href=f"{app_name}",
1521
sticky="top",
1622
color="light",
1723
dark=False,

0 commit comments

Comments
 (0)