-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addMany has strange behavior for files with only one extension #370
Comments
I looked at the implementation and I agree that it doesn't seem right. I'm not sure why we have it check to be sure there's an extension after the strip happens. Maybe there was an assumption that a |
Yeah, looking at the original issue and original PR it looks like the behavior was intentional. The author called it out in their examples and tests. I think that making it so that I think I'll raise a PR to update the behavior when |
Hi!
I was trying to use plop to scaffold a new server, and I saw that
addMany
had some strange behavior on dockerfiles. When my template directory contained aDockerfile.hbs
andDockerfile.test.hbs
, the target directory containsDockerfile.hbs
andDockerfile.test
. Plop strips the extension from the test file, but not the main one.I think the reason is that the main file only has the
.hbs
extension. Looking at the implementation, it looks like extension stripping only works if there's still an extension left after the.hbs
is removed.Is this a bug? Or is it a feature? And either way, would you accept a pull request to change that behavior?
The text was updated successfully, but these errors were encountered: